Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWZa2-0002mo-G4 for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Mar 2022 08:09:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWZZz-0000Gb-SF for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Mar 2022 08:09:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWZZz-0000GS-GL for pgsql-hackers@lists.postgresql.org; Tue, 22 Mar 2022 08:09:23 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWZZw-00046j-St for pgsql-hackers@lists.postgresql.org; Tue, 22 Mar 2022 08:09:22 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 278F23200D78; Tue, 22 Mar 2022 04:09:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 Mar 2022 04:09:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=g5pYPCqbQ+2ngt1LtuvHpwAlEaB9Li9PtNu/jL21v jE=; b=hoqvFPqhbsjQgk9lagZUWgUDAjZ3skTluJlG1AIeEt8i4My1l5GoDIWSi /t9xClyihKilx/43y3/+h4xechTgF1bvH6B7s1rHNLYGTA60dLm9y44AQDrirElj tx+wZkCeiJWzrIKrRPjoSpuDpYoTp+G1mhh3FmHuGTujZAgJNPsZTgahz8pK/OZF DY3gz2rkgwvsPQYNHgCoiuh65ZABS3L6fSNtmZCVIhnITbYRBTyh3a9C4OcIs2Lk y2yhb4+p6FWlqe48ms7kdiZJUVimXWwmZgJu9PnNMrWvhBLYMIKrJTi97QWpXs9E rO9T+Cuiw2dpW3zX1fD6vZp8eTUag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeggedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelgfetfeeitdelleeg geejvefhueetfedvtdejheevueeifeegvdfhueeludetueenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Mar 2022 04:09:17 -0400 (EDT) Message-ID: <123965dd-d9cb-f7c8-6efa-49a10be1cb39@enterprisedb.com> Date: Tue, 22 Mar 2022 09:09:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: logical decoding and replication of sequences Content-Language: en-US To: Tomas Vondra Cc: Amit Kapila , PostgreSQL Hackers , Petr Jelinek References: <802f8b1b-a798-be52-c829-7f0fb9faafd5@enterprisedb.com> <983bf0c7-9757-fd13-3896-8452cf4c4c52@enterprisedb.com> <9211312a-6501-1caf-ee7b-c0d4814b6091@enterprisedb.com> <41ada110-bc7c-32a3-08bd-fb5023dd74ba@enterprisedb.com> <2eed0f76-3a1a-8b8b-ac1b-e0f9a0d98287@enterprisedb.com> <9defb937-20a9-1d9f-6972-f1c4b4da4f73@enterprisedb.com> <8e766e0f-ed3e-fd68-4b0f-10dd2db60c88@enterprisedb.com> <6b21233e-c880-e4ad-5df2-7832f769296c@enterprisedb.com> <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com> <9d8b3351-9094-0ae9-ae7c-e03bab81a6ec@enterprisedb.com> From: Peter Eisentraut In-Reply-To: <9d8b3351-9094-0ae9-ae7c-e03bab81a6ec@enterprisedb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 21.03.22 22:54, Tomas Vondra wrote: > On 3/21/22 14:05, Peter Eisentraut wrote: >> On 20.03.22 23:55, Tomas Vondra wrote: >>> Attached is a rebased patch, addressing most of the remaining issues. >> >> This looks okay to me, if the two FIXMEs are addressed.  Remember to >> also update protocol.sgml if you change LOGICAL_REP_MSG_SEQUENCE. > > Thanks. Do we want to use a different constant for the sequence message? > I've used 'X' for the WIP patch, but maybe there's a better value? I would do small 's'. Alternatively, 'Q'/'q' is still available, too.