Subject: Re: New trigger option of pg_standby
From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <4A095A39.3030100@enterprisedb.com>
References: <3f0b79eb0903242329j12865d55s348f5c873a956e71@mail.gmail.com>
	<49DDEE72.6030803@enterprisedb.com>
	<3f0b79eb0904092047w355e0b3ar527a9285b161ef91@mail.gmail.com>
	<1239381103.16396.30.camel@ebony.2ndQuadrant>
	<3f0b79eb0904122252t1f4c5860v919d199f399ccf72@mail.gmail.com>
	<3f0b79eb0904132241p18084914g792cb8e5ab3eebb3@mail.gmail.com>
	<3f0b79eb0904150101pb1c59a3ubb422867e8e6a944@mail.gmail.com>
	<49EE1E3F.9050307@enterprisedb.com>
	<3f0b79eb0904212209i7fbd8b68k71db1fef09c62751@mail.gmail.com>
	<49F01D79.8020805@enterprisedb.com>
	<3f0b79eb0904230515p751b5248n6ef96880617db055@mail.gmail.com>
	<4A095A39.3030100@enterprisedb.com>
Content-Type: text/plain
Date: Tue, 12 May 2009 12:27:03 +0100
Message-Id: <1242127623.3843.237.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Tue, 2009-05-12 at 14:15 +0300, Heikki Linnakangas wrote:

> Here's another idea: Let's modify xlog.c so that when the server asks 
> for WAL file X, and restore_command returns "not found", the server
> will not ask for any WAL files >= X again (in that recovery session). 
> Presumably if X doesn't exist, no later files will exist either.

That was proposed and rejected earlier, though not in this context.
Sounds fine to me.

I agree that we should simplify/clarify the file request pattern, which
is the source of many difficulties over last few years.

I would further propose that I take pg_standby out as a module, so we
can more easily support earlier releases.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support