Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lzhV0-0004Cj-4h
	for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Jul 2021 15:24:06 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lzhUz-0006EN-2W
	for pgsql-hackers@arkaria.postgresql.org; Sat, 03 Jul 2021 15:24:05 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lzhUy-0006E4-Mh
	for pgsql-hackers@lists.postgresql.org; Sat, 03 Jul 2021 15:24:04 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lzhUw-0001xN-PJ
	for pgsql-hackers@postgresql.org; Sat, 03 Jul 2021 15:24:03 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 163FNuON1242587;
	Sat, 3 Jul 2021 11:23:56 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
cc: "alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>,
        "daniel@yesql.se" <daniel@yesql.se>, "info@cspug.cz" <info@cspug.cz>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        "michael@paquier.xyz" <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <1188534.1625267321@sss.pgh.pa.us>
References: <202107022303.kjy5q4wym6gj@alvherre.pgsql>
 <1188534.1625267321@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 02 Jul 2021 19:08:41 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1242585.1625325836.1@sss.pgh.pa.us>
Date: Sat, 03 Jul 2021 11:23:56 -0400
Message-ID: <1242586.1625325836@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1242586.1625325836%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Hmmm ... mine is 8.4.1.
> I'm about to go out to dinner, but will check into this with some
> newer gcc versions later.

Tried --enable-coverage on Fedora 34 (with gcc 11.1.1) and sure
enough there's an exit() call being inserted.  I've pushed a fix
to just disable the check altogether in --enable-coverage builds.

			regards, tom lane