Subject: Re: New trigger option of pg_standby
From: Simon Riggs <simon@2ndQuadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <200905271313.n4RDDg404900@momjian.us>
References: <200905271313.n4RDDg404900@momjian.us>
Content-Type: text/plain
Date: Wed, 27 May 2009 14:41:18 +0100
Message-Id: <1243431678.24860.186.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Wed, 2009-05-27 at 09:13 -0400, Bruce Momjian wrote:
> Tom Lane wrote:
> > Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> > > I don't think we're going to get this to work reliably without extending 
> > > the interface between the backend and restore_command. We've discussed 
> > > many methods and there's always some nasty corner-case like that.
> > 
> > > I think we should leave back-branches as is, and go with Simon's 
> > > suggestion to add new "recovery_end_command" that's run when the 
> > > recovery is finished. That's simpler and more reliable than any of the 
> > > other approaches we've discussed, and might become handy for other 
> > > purposes as well.
> > 
> > > Does someone want to take a stab at writing a patch for that?
> > 
> > Does this conclusion mean that changing pg_standby is no longer
> > on the table for 8.4?  It certainly smells more like a new feature
> > than a bug fix.
> 
> I think the big frustration is that this issue was first brought up
> March 25 and it took two months to resolve it, at which point we were in
> beta.  I think many hoped a better idea would emerge but often that just
> doesn't happen and we have to do the best fix we can and move on.

I agree, very frustrating. Why do you bring it up again now? 

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support