Subject: Re: New trigger option of pg_standby
From: Simon Riggs <simon@2ndQuadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <200905271608.n4RG8tW06393@momjian.us>
References: <200905271608.n4RG8tW06393@momjian.us>
Content-Type: text/plain
Date: Wed, 27 May 2009 17:54:36 +0100
Message-Id: <1243443276.24860.279.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Wed, 2009-05-27 at 12:08 -0400, Bruce Momjian wrote:
> Simon Riggs wrote:
> > 
> > On Wed, 2009-05-27 at 09:48 -0400, Bruce Momjian wrote:
> > 
> > > We are not going to improve unless we face our faults.
> > 
> > True. Who or what is at fault, in your opinion?
> 
> Well, we knew there was an issue but we didn't finalize our conclusions
> and address it as best we could before beta;  instead it languished and
> was only addressed when we had our back up against the wall for beta2. 
> Obviously this is not the best aproach.  Ideally someone would have
> taken ownership of the issue, summarized the email conclusions, gotten a
> patch together, and submitted it for application.  I know patches were
> posted but no one got group consensus on its usefulness until recently.

My experience is that consensus/votes will be overruled by final
committer, if they disagree, and so only a committer has the real
authority to take the role you suggest.

http://en.wiktionary.org/wiki/responsibility
"The obligation to carry forward an assigned task to a successful
conclusion. With responsibility goes authority to direct and take the
necessary action to ensure success"

From my side, Fujii-san's patch was adequate and backpatchable, though
needed docs changes; I proposed it should be committed and said so
clearly on open items wiki. My own suggestion was also an option, but it
was also clearly not backpatchable and seemed unlikely to be acceptable
at any time, let alone during beta. I am surprised at the final outcome,
but at least there is one, which is good.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support