Subject: Re: New trigger option of pg_standby
From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
In-Reply-To: <4A1D5099.8070106@enterprisedb.com>
References: <200905271351.n4RDpuV12108@momjian.us>
	<4A1D5099.8070106@enterprisedb.com>
Content-Type: text/plain
Date: Wed, 27 May 2009 19:24:23 +0100
Message-Id: <1243448663.24860.326.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Wed, 2009-05-27 at 17:39 +0300, Heikki Linnakangas wrote:

> I agree we could've should've handled this more promptly, and I'll take 
> my part of the blame for that. I let the various proposed patches sit 
> for long times before reviewing them thoroughly, partly because I was 
> busy and partly because I didn't feel good about the proposed 
> approaches. I think what went in in the end is pretty simple and robust, 
> but it's a shame we had to rush to get it into beta2, after sitting on 
> our thumbs for months.

Through everything I just said, I have no criticism of you Heikki. I had
the same emotions about the proposals. I was only explaining why I felt
unable to speed up the process myself.

Final patch took me an hour to code and test, so I wasn't put out or
rushed.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support