Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waEu6-001d03-14
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 18 Jun 2026 15:43:42 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1waEu5-00CGpn-0Z
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 18 Jun 2026 15:43:41 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1waEu4-00CGpf-2q
	for pgsql-hackers@lists.postgresql.org;
	Thu, 18 Jun 2026 15:43:40 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1waEu3-00000000zjA-2kPR
	for pgsql-hackers@lists.postgresql.org;
	Thu, 18 Jun 2026 15:43:40 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 65IFhcFN1243457;
	Thu, 18 Jun 2026 11:43:38 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: fix pg_mkdir_p to tolerate concurrent directory creation
In-reply-to: <89be878a-abc1-4000-9dd2-8422d561a24b@dunslane.net>
References: <3ca004de-e49b-4471-b8aa-fd656e70f68c@dunslane.net>
 <1231927.1781792643@sss.pgh.pa.us>
 <89be878a-abc1-4000-9dd2-8422d561a24b@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Thu, 18 Jun 2026 11:37:49 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1243455.1781797418.1@sss.pgh.pa.us>
Date: Thu, 18 Jun 2026 11:43:38 -0400
Message-ID: <1243456.1781797418@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1243456.1781797418%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> Oh, good catch, thanks! Here's a revised patch.

The Unix side of this LGTM.  I have no idea about the Windows
half (... but are we sure GetFileAttributes() can't change errno?)

			regards, tom lane