Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 5E66B633ADB for ; Thu, 28 May 2009 10:37:20 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 03497-04 for ; Thu, 28 May 2009 10:37:16 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail136024.authsmtp.net (outmail136024.authsmtp.net [62.13.136.24]) by mail.postgresql.org (Postfix) with ESMTP id 29B21633815 for ; Thu, 28 May 2009 10:35:19 -0300 (ADT) Received: from mail-c188.authsmtp.com (mail-c188.authsmtp.com [62.13.128.25]) by punt5.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id n4SDZG4d036558; Thu, 28 May 2009 14:35:16 +0100 (BST) Received: from [192.168.0.2] (85-211-225-42.dyn.gotadsl.co.uk [85.211.225.42]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id n4SDZEpq051851; Thu, 28 May 2009 14:35:14 +0100 (BST) Subject: Re: New trigger option of pg_standby From: Simon Riggs To: Bruce Momjian Cc: pgsql-hackers In-Reply-To: <200905271608.n4RG8tW06393@momjian.us> References: <200905271608.n4RG8tW06393@momjian.us> Content-Type: text/plain Date: Thu, 28 May 2009 14:38:38 +0100 Message-Id: <1243517918.24860.563.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Server-Quench: 604b06e8-4b8c-11de-85ee-001871e930f4 X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MJUcNSQVJ NksadBtFag1bYFhI HGQLW11EUVl7WmZ/ ag8fZQBDYEtPQQdo VVZNQE1QEQdtHhxP WBp9JnMHN0RGfX94 YEcsX3NYXQp8dUIv QkgBHXACN28zdWEe BBVFfwYBJR5Kfh5N bVEqXXANN2FJBC9q VzwTFhsSEA9kHWxz Tx5FMUgTTkkGBHY7 XwwDGjNnGkNNXyoE NAAvLFIWDS42 X-Authentic-SMTP: 61633235383639.cat.dmpriest.net.uk:1562/Kp X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200905/1229 X-Sequence-Number: 138771 On Wed, 2009-05-27 at 12:08 -0400, Bruce Momjian wrote: > Ideally someone would have > taken ownership of the issue, summarized the email conclusions, gotten > a patch together, and submitted it for application. Just a further comment on this, based upon the patch Heikki recently committed. I raised various issues with recovery *after* feature freeze in 8.3, doing everything you mentioned above: patch (Jun '07), 4 months before beta1. 3.5 months later the patch was still un-reviewed and you deferred the patch until 8.4, without comment (Sep '07). Changes were eventually committed more than a year after original discussion (Apr '08). HACKERS "Minor changes to recovery related code" My other comments relate to that experience, and others. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support