public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Pavel Stehule <[email protected]>
Cc: Kirk Wolak <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID
Date: Mon, 03 Apr 2023 13:37:31 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFj8pRD6ti-bsYH_tObUNznZ_kiPcvDnty0oLW5j2MoGnODoFQ@mail.gmail.com>
References: <CAFj8pRA4zMd5pY-B89Gm64bDLRt-L+akOd34aD1j4PEstHHSVQ@mail.gmail.com>
<20230208063316.atjv6uxb7owm77s6@jrouhaud>
<CAFj8pRBEwu3FwFvjOn0oB9hO0Rnipzko9r0bHj248CJgowza6w@mail.gmail.com>
<CACLU5mSUj9cbGB9wQAABnOgYGUg95awzBhhTB1P79fL-NfYTDw@mail.gmail.com>
<CACLU5mRkaePuCMqiFVKg54jTn1PjT-mCnj-2zvUaKA3sHr0MCg@mail.gmail.com>
<CACLU5mSgxBXphh_rN-7r3iXjq4ymEtcBsibHwVR0kvLJKQwD9g@mail.gmail.com>
<CAFj8pRD6ti-bsYH_tObUNznZ_kiPcvDnty0oLW5j2MoGnODoFQ@mail.gmail.com>
Pavel Stehule <[email protected]> writes:
> po 27. 3. 2023 v 5:36 odesÃlatel Kirk Wolak <[email protected]> napsal:
>> I have marked the item Ready for Commiter...
> Thank you for doc and for review
I'm kind of surprised there was any interest in this proposal at all,
TBH, but apparently there is some. Still, I think you over-engineered
it by doing more than the original proposal of making the function OID
available. The other things can be had by casting the OID to regproc
or regprocedure, so I'd be inclined to add just one new keyword not
three. Besides, your implementation is a bit inconsistent: relying
on fn_signature could return a result that is stale or doesn't conform
to the current search_path.
regards, tom lane
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox