Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1of66T-0007hE-DZ
	for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Oct 2022 21:02:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1of66S-0006PX-8B
	for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Oct 2022 21:02:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1of66R-0006Nu-Uh
	for pgsql-hackers@lists.postgresql.org; Sun, 02 Oct 2022 21:02:23 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1of66P-00054R-J2
	for pgsql-hackers@postgresql.org; Sun, 02 Oct 2022 21:02:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 292L2GqG1246780;
	Sun, 2 Oct 2022 17:02:16 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        John Naylor <john.naylor@enterprisedb.com>,
        Julien Rouhaud <rjuju123@gmail.com>, Erik Rijkers <er@xs4all.nl>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Tomas Vondra <tomas.vondra@enterprisedb.com>,
        Dean Rasheed <dean.a.rasheed@gmail.com>,
        Stephen Frost <sfrost@snowman.net>,
        Surafel Temesgen <surafel3000@gmail.com>,
        vignesh C <vignesh21@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: proposal: possibility to read dumped table's name from file
In-reply-to: <098531E1-FBA9-4B7D-884E-0A4363EEE6DF@yesql.se>
References: 
 <CAFBsxsFELC2NWVhht_f3ut5xt1m+bg21d=J-g=d-ysXObnofBA@mail.gmail.com>
 <A9A76268-A5F7-4922-888E-E813CC9A9493@dunslane.net>
 <69662E57-652D-4123-89E4-3BC6742B47F8@yesql.se>
 <20221002065659.i2uvszybojznudge@awork3.anarazel.de>
 <20221002071959.ygtdkbzetdbnvcl4@awork3.anarazel.de>
 <20221002160413.x7stjt2bdvnjvra3@awork3.anarazel.de>
 <098531E1-FBA9-4B7D-884E-0A4363EEE6DF@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Sun, 02 Oct 2022 22:52:33 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1246778.1664744536.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 02 Oct 2022 17:02:16 -0400
Message-ID: <1246779.1664744536@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1246779.1664744536%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 2 Oct 2022, at 18:04, Andres Freund <andres@anarazel.de> wrote:
>> c.h (and postgres.h, postgres_fe.h) shouldn't be included in headers.
>> This is a common enough mistake that I'm wondering if we could automate
>> warning about it somehow.

> Maybe we can add a simple git grep invocation in the CompilerWarnings CI=
 job to
> catch this in the CFBot?

I'd be inclined to teach headerscheck or cpluspluscheck about it.

			regards, tom lane