From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Simon Riggs <simon@2ndquadrant.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Dean Rasheed <dean.a.rasheed@gmail.com>
Subject: Re: WITH clause in CREATE STATISTICS
In-reply-to: <20170511221330.5akgbsoyx6wm4u34@alvherre.pgsql>
References: <20170511221330.5akgbsoyx6wm4u34@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 11 May 2017 19:13:30 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12493.1494542232.1@sss.pgh.pa.us>
Date: Thu, 11 May 2017 18:37:12 -0400
Message-ID: <12494.1494542232@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> BTW the new castNode() family of macros don't work with Value nodes
> (because the tags are different depending on what's stored, but each
> type does not have its own struct.  Oh well.)

Yeah.  Value nodes are pretty much of a wart --- it's not clear to me
that they add anything compared to just having a separate node type
for each of the possible subclasses.  It's never bothered anyone enough
to try to replace them, though.

I'll take a look at the patch later.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers