From: Tom Lane <tgl@sss.pgh.pa.us>
To: Piotr Stefaniak <postgres@piotr-stefaniak.me>
cc: Bruce Momjian <bruce@momjian.us>, Andres Freund <andres@anarazel.de>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "Stephen
 Frost" <sfrost@snowman.net>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Preliminary results for proposed new pgindent implementation
In-reply-to: 
 <VI1PR03MB1199CEA13AEFE46308D9F7F5F2C10@VI1PR03MB1199.eurprd03.prod.outlook.com>
References: <20170519173111.zp6igkcg53egdy4s@alvherre.pgsql>
 <cb9eebd2-0214-1f34-51af-ebb69ec8a711@2ndquadrant.com>
 <29275.1497624664@sss.pgh.pa.us> <8827.1497633050@sss.pgh.pa.us>
 <20170616171946.qqy5tapovsamkxyg@alap3.anarazel.de>
 <9900.1497634441@sss.pgh.pa.us>
 <20170616180534.cdpduuq5a4twxuru@alap3.anarazel.de>
 <12302.1497637380@sss.pgh.pa.us> <20170616184238.GA5081@momjian.us>
 <20170616185406.jpwq6o6ghpvprxmi@alap3.anarazel.de>
 <20170616190441.GB5081@momjian.us> <29590.1497643007@sss.pgh.pa.us>
 <VI1PR03MB1199CEA13AEFE46308D9F7F5F2C10@VI1PR03MB1199.eurprd03.prod.outlook.com>
Comments: In-reply-to Piotr Stefaniak <postgres@piotr-stefaniak.me>
	message dated "Fri, 16 Jun 2017 20:30:21 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12516.1497650535.1@sss.pgh.pa.us>
Date: Fri, 16 Jun 2017 18:02:15 -0400
Message-ID: <12517.1497650535@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 2017-06-16 21:56, Tom Lane wrote:
>> Unless Piotr objects, I propose to add another switch to bsdindent
>> that selects this behavior, and then we can drop entab, removing
>> another impediment to getting pgindent working.

> I understand the reasoning, but this is a very specific need and I think
> not at all universal for anyone else in the future. One of the bugs
> listed in indent's manpage is that it "has more switches than ls(1)". So
> currently I'm against pushing an option for the above upstream, to the
> FreeBSD repository.

> Why not add this to the already non-empty list of custom patches?

Umm ... I thought the idea was to get to the point where the list of
custom patches *is* empty.  Except for carrying our own Makefile of
course.  I'd be sad if we needed a fork just for this.

What I'm testing with right now has just four differences from your repo:

1. This workaround for what I believe you agree is a bug:

-	    ps.in_decl = ps.decl_on_line = ps.last_token != type_def;
+	    ps.in_decl = ps.decl_on_line = true;

2. The long-lines adjustment I just sent you a patch for.

3. The tab-vs-space difference under discussion here.

4. A temporary hack affecting the indentation of comments on the same line
(forcing them to a multiple of 8 spaces even though tabsize is 4).  I have
every intention of dropping that one later; I just don't want to deal with
comment reindentation at the same time as these other things.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers