Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsXtb-0007dM-M1 for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 16:21:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsXtb-0000tT-49 for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 16:21:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsXsC-0007Xs-Vm for pgsql-hackers@postgresql.org; Fri, 07 Oct 2016 16:19:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsXs6-0001nN-EZ for pgsql-hackers@postgresql.org; Fri, 07 Oct 2016 16:19:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u97GJNMr012567; Fri, 7 Oct 2016 12:19:24 -0400 From: Tom Lane To: Robert Haas cc: Heikki Linnakangas , Kyotaro HORIGUCHI , "Tsunakawa, Takayuki" , Tatsuo Ishii , "pgsql-hackers@postgresql.org" Subject: Re: Radix tree for character conversion In-reply-to: References: <20160908.153546.187438961.horiguchi.kyotaro@lab.ntt.co.jp> <7ff67a45-a53e-4d38-e25d-3a121afea47c@iki.fi> <20160921.151427.265121484.horiguchi.kyotaro@lab.ntt.co.jp> <20161007.173606.217452136.horiguchi.kyotaro@lab.ntt.co.jp> Comments: In-reply-to Robert Haas message dated "Fri, 07 Oct 2016 11:55:10 -0400" Date: Fri, 07 Oct 2016 12:19:23 -0400 Message-ID: <12566.1475857163@sss.pgh.pa.us> X-Pg-Spam-Score: -4.6 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Fri, Oct 7, 2016 at 6:46 AM, Heikki Linnakangas wrote: >> Ouch. We should find and document an authoritative source for all the >> mappings we have... >> >> I think the next steps here are: >> >> 1. Find an authoritative source for all the existing mappings. >> 2. Generate the radix tree files directly from the authoritative sources, >> instead of the existing *.map files. >> 3. Completely replace the existing binary-search code with this. > It might be best to convert using the existing map files, and then > update the mappings later. Otherwise, when things break, you won't > know what to blame. I think I went through this exercise last year or so, and updated the notes about the authoritative sources where I was able to find one. In the remaining cases, I believe that the maps have been intentionally tweaked and we should be cautious about undoing that. Tatsuo-san might remember more about why they are the way they are. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers