Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfoZV-0004k2-KR for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Aug 2017 14:36:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dfoZV-0008K4-5o for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Aug 2017 14:36:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dfoZU-0008Jv-Ni for pgsql-hackers@postgresql.org; Thu, 10 Aug 2017 14:36:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dfoZR-00016l-A8 for pgsql-hackers@postgresql.org; Thu, 10 Aug 2017 14:36:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v7AEaBqq012589; Thu, 10 Aug 2017 10:36:11 -0400 From: Tom Lane To: Robert Haas cc: Ashutosh Sharma , Sandeep Thakkar , Christoph Berg , pgsql-hackers Subject: Re: pl/perl extension fails on Windows In-reply-to: References: <4569.1499873707@sss.pgh.pa.us> <20170713195345.2q6zmrtxumljhoui@msg.df7cb.de> <3254.1501276475@sss.pgh.pa.us> <20170730211444.uvedz2a24gusoaxr@msg.df7cb.de> <20170731084044.q3wmppgt556zafzy@msg.df7cb.de> <30582.1501508356@sss.pgh.pa.us> <20170731164517.a34wxaapos7u5toj@msg.df7cb.de> Comments: In-reply-to Robert Haas message dated "Thu, 10 Aug 2017 10:17:14 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12587.1502375771.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 10 Aug 2017 10:36:11 -0400 Message-ID: <12588.1502375771@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Thu, Aug 10, 2017 at 8:30 AM, Ashutosh Sharma = wrote: >> So, the question is should we allow the preprocessor option >> '_USE_32BIT_TIME_T' to be defined implicitly or not in postgresql >> provided we are using Visual C compiler version > 8.0. I think this >> should make plperl compatible with perl binaries. > We've got this code in MSBuildProject.pm and VCBuildProject.pm: > # We have to use this flag on 32 bit targets because the 32bit pe= rls > # are built with it and sometimes crash if we don't. > my $use_32bit_time_t =3D > $self->{platform} eq 'Win32' ? '_USE_32BIT_TIME_T;' : ''; > Based on the discussion upthread, I think we now know that this was > not really the right approach. Yeah ... however, if that's there, then there's something wrong with Ashutosh's explanation, because that means we *are* building with _USE_32BIT_TIME_T in 32-bit builds. It's just getting there in a roundabout way. (Or, alternatively, this code is somehow not doing anything at all.) > The trouble with that is that _USE_32BIT_TIME_T also affects how > PostgreSQL code compiles. Really? We try to avoid touching "time_t" at all in most of the code. I bet that we could drop the above-cited code, and compile only plperl with _USE_32BIT_TIME_T, taken (if present) from the Perl flags, and it'd be fine. At least, that's my first instinct for what to try. regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers