From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: David Rowley <dgrowleyml@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep
 size
In-reply-to: <20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de>
References: <20220616233130.rparivafipt6doj3@alap3.anarazel.de>
 <CAApHDvo3GOUK2YFJTjcECvB=0Jx==S-ywcVno9U1rZT_7r7+dg@mail.gmail.com>
 <CAH2-WznM2gGO7O0w1sWYdBV3U6RLZvRhoWEr20+dS02QV3hqjA@mail.gmail.com>
 <CAApHDvqivvMw=AgvVQA+dKEQJHxV5JVS8Nm48NZA+FT8vuuDcw@mail.gmail.com>
 <20220617052228.mjwns6ugspihamsc@alap3.anarazel.de>
 <20220617062456.ahbwho67m7c3lnr3@alap3.anarazel.de>
 <1221363.1655476388@sss.pgh.pa.us>
 <20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 17 Jun 2022 10:30:55 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1261895.1655487829.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 17 Jun 2022 13:43:49 -0400
Message-ID: <1261896.1655487829@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1261896.1655487829%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I should have been more precise - what I meant was a timeout.c API that =
allows
> the caller to pass in "now", which in this case we'd get from
> GetCurrentTransactionStopTimestamp(), which would avoid the additional
> timestamp computation.

I don't care for that one bit: it makes the accuracy of all timeouts
dependent on how careful that caller is to provide an up-to-date "now".
In the example at hand, there is WAY too much code between
SetCurrentTransactionStopTimestamp() and the timer arming to make me
think the results will be acceptable.

			regards, tom lane