Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 9E6D5633575 for ; Sun, 27 Dec 2009 18:10:23 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 80798-10 for ; Sun, 27 Dec 2009 22:10:16 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail137091.authsmtp.co.uk (outmail137091.authsmtp.co.uk [62.13.137.91]) by mail.postgresql.org (Postfix) with ESMTP id 0F38C633557 for ; Sun, 27 Dec 2009 18:10:15 -0400 (AST) Received: from mail-c194.authsmtp.com (mail-c194.authsmtp.com [62.13.128.121]) by punt4.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id nBRMADAY031566; Sun, 27 Dec 2009 22:10:13 GMT Received: from [192.168.0.3] (88-110-178-52.dynamic.dsl.as9105.com [88.110.178.52]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id nBRMAAlN000150; Sun, 27 Dec 2009 22:10:11 GMT Subject: Re: Small locking bugs in hs From: Simon Riggs To: Andres Freund Cc: pgsql-hackers@postgresql.org In-Reply-To: <200912272012.32556.andres@anarazel.de> References: <200912272012.32556.andres@anarazel.de> Content-Type: text/plain Date: Sun, 27 Dec 2009 22:10:09 +0000 Message-Id: <1261951809.18116.458.camel@ebony> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Server-Quench: 9a081946-f334-11de-80b9-0022640b883e X-Report-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCdxZQATClZOTQEd DAteCiN5VAwpPBRK HVkIKg5MJUcNSQVJ NksadBtFagJbaVxS HGQLW11EUl97WGN/ agsfZQ1DY0tOQQRt WFZMQE1XHAJ3AVJf dHxjI2guCQVGeH91 ZQhjV3hfEk0rdU58 S0pSCDsFZmN9aWFL BV1Qd1FdbQNKfB1D blAtXHsONCtlM3Bw JAo6OzR5OTJUKyVT TUkHMF0JCUcNVj4n LwAA X-Authentic-SMTP: 61633235383639.1015:706/Kp X-AuthFastPath: 255 X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200912/2142 X-Sequence-Number: 152845 On Sun, 2009-12-27 at 20:12 +0100, Andres Freund wrote: > While unlikely to cause issues two new LWLockAcquire calls use the wrong > locking mode. > Patch attached. It's important to explain why you think something is a bug, rather than make that claim on its own. The locking mode was intentional, though not documented either way. However, I think I see a different issue with conflict handling, so looking at this again was worthwhile, thanks. Will come back with more over next few days. -- Simon Riggs www.2ndQuadrant.com