From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Michael Paquier <michael.paquier@gmail.com>,
        Haribabu Kommi <kommi.haribabu@gmail.com>,
        Dmitry Vasilyev <d.vasilyev@postgrespro.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re:
 =?UTF-8?Q?Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKE?=
 =?UTF-8?Q?RS=5D_Re=3A_=5BHACKERS=5D_Re=3A_=5BHACKERS=5D_Windows_service_is_not_start?=
 =?UTF-8?Q?ing_so_there=E2=80=99s_message_in_log=3A_FATAL=3A_=22could_not_create_sh?=
 =?UTF-8?Q?ared_memory_segment_=E2=80=9CGlobal=2FPostgreSQL=2E851401618=E2=80=9D=3A_Permi?=
 =?UTF-8?Q?ssion_denied=E2=80=9D?=
In-reply-to: 
 <CAA4eK1+9C2Bn9zAPTgUYMT=Koes1GAiaDpKikfns2WQPjKeAGA@mail.gmail.com>
References: <1444920387.3661.7.camel@postgrespro.ru>
 <1444921511.3661.13.camel@postgrespro.ru>
 <CAA4eK1+pjtDouF-Lc9y0UgFDmWHnaf4KwiM1Y3Anq0wZ1gwsAA@mail.gmail.com>
 <CA+TgmoZiYV=fFnWQZbfjZ250=YYxAWn_XETGVdUpwFnKxd7B9A@mail.gmail.com>
 <CAA4eK1K-c0P7_RVRUFrkgQyy-X4JC1rDyHpZiUQeJJJPpAy_jw@mail.gmail.com>
 <31461.1445090619@sss.pgh.pa.us>
 <CAJrrPGfkMyYmr+7fki+nKsWGZ0LOXMgPJSixSFo=uL6MFF=OGQ@mail.gmail.com>
 <CAA4eK1JTS3bOUX8KHGJrhGs5i54FdbU0Ez4PMqDqj5r_KvwKOQ@mail.gmail.com>
 <CAJrrPGcC27MYAmeHq=o8zo52c+-X7NbrzF26d1CZBS-JQkHaYQ@mail.gmail.com>
 <CAA4eK1J7mSohkNb2q0yUn8aFdfaR66jH3HnWi6pT4XaXRrdxjQ@mail.gmail.com>
 <CAJrrPGcT8URvcyeWzZcHgB6PVyus-r785thn6vUGZ9SyA3Kq8A@mail.gmail.com>
 <CAA4eK1LSqMRWnjnakWejfKg8_Bt7DZvBTHUsYbP1MerXxX7YYw@mail.gmail.com>
 <CAJrrPGfnFB+wmc3FMo6f9fC+p5+mevw5nQdkMSqfTB-1Ey=wmA@mail.gmail.com>
 <CAA4eK1K+c3Scr4WPcnt6=UQX6ZttJkHOe5+UQ3mMtjAnq2xGdQ@mail.gmail.com>
 <CAJrrPGcEyYbffNh6VEpXaykVsGthvZ7Qhn4d6TmxsHda5MPDtQ@mail.gmail.com>
 <20811.1474390987@sss.pgh.pa.us> !
 <CAA4eK1Jhr8BHB6hTa4XCiQPdzZYRtThyekXo39XvVvKiJb7w_g@mail.gmail.com>
 <29726.1474564208@sss.pgh.pa.us>
 <CAA4eK1+9C2Bn9zAPTgUYMT=Koes1GAiaDpKikfns2WQPjKeAGA@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Fri, 23 Sep 2016 15:27:54 +0530"
Date: Fri, 23 Sep 2016 10:11:42 -0400
Message-ID: <12624.1474639902@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Amit Kapila <amit.kapila16@gmail.com> writes:
> Attached patch tightens the error handling.  However, on debugging, I
> found that CreateFileMapping() always set error code to 0 on success.

Ah, interesting.

> Now, it is quite possible
> that error code is set to 0 on success in my windows environment
> (Win7) and doesn't work in some other environment.  In any case, if we
> want to go ahead and don't want to rely on CreateFileMapping(), then
> attached patch should suffice the need.

Yeah, seeing that this is not mentioned in MS' documentation I don't
think we should rely on it.  The patch looks fine to me, pushed.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers