Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRkyU-0001UV-9i for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Jun 2018 21:00:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fRkyT-0003HE-2x for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Jun 2018 21:00:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRkyS-0003H5-OI for pgsql-hackers@lists.postgresql.org; Sat, 09 Jun 2018 21:00:36 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRkyQ-0004wQ-0H for pgsql-hackers@lists.postgresql.org; Sat, 09 Jun 2018 21:00:35 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w59L0QLm012625; Sat, 9 Jun 2018 17:00:26 -0400 From: Tom Lane To: David Rowley cc: Amit Langote , Dmitry Dolgov <9erthalion6@gmail.com>, Jeff Janes , Ashutosh Bapat , Pavel Stehule , PostgreSQL Hackers Subject: Re: why partition pruning doesn't work? In-reply-to: <6366.1528571895@sss.pgh.pa.us> References: <7142.1527868419@sss.pgh.pa.us> <1111.1527977170@sss.pgh.pa.us> <10432.1528045900@sss.pgh.pa.us> <569483c5-a273-6537-1b5d-7a271ce439fb@lab.ntt.co.jp> <22805.1528386192@sss.pgh.pa.us> <21787.1528428171@sss.pgh.pa.us> <6366.1528571895@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Sat, 09 Jun 2018 15:18:15 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12623.1528578026.1@sss.pgh.pa.us> Date: Sat, 09 Jun 2018 17:00:26 -0400 Message-ID: <12624.1528578026@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > One thing I'm wondering about is why in the world are PartitionPruneInfo > and its subsidiary struct types declared in primnodes.h? Oh, and while I'm bitching: it seems like there is hardly any part of the partitioning code in which the comments aren't desperately in need of a copy-editing pass. They are just chock-full of misspellings, grammar that is faulty enough to make the meaning unclear, and/or errors of fact. An example of the latter is the repeated claims that the basic partitioning functions belong to the planner. Maybe that was true at some stage of development; but AFAICS the logic in question now lives in src/backend/partitioning/, which I would not think is part of the planner. regards, tom lane