Received: from maia.hub.org (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 446AF632AC3 for ; Sat, 16 Jan 2010 07:32:56 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 43522-06 for ; Sat, 16 Jan 2010 11:32:38 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail128053.authsmtp.com (outmail128053.authsmtp.com [62.13.128.53]) by mail.postgresql.org (Postfix) with ESMTP id 7EC78632A98 for ; Sat, 16 Jan 2010 07:32:44 -0400 (AST) Received: from mail-c194.authsmtp.com (mail-c194.authsmtp.com [62.13.128.121]) by punt8.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id o0GBWfBJ005747; Sat, 16 Jan 2010 11:32:41 GMT Received: from [192.168.0.3] (88-110-134-25.dynamic.dsl.as9105.com [88.110.134.25]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id o0GBWaZ0042514; Sat, 16 Jan 2010 11:32:38 GMT Subject: Re: Small locking bugs in hs From: Simon Riggs To: Robert Haas Cc: Andres Freund , pgsql-hackers@postgresql.org In-Reply-To: <603c8f071001071016h211ff0e2x41fea95835f74fb4@mail.gmail.com> References: <200912272012.32556.andres@anarazel.de> <603c8f071001071016h211ff0e2x41fea95835f74fb4@mail.gmail.com> Content-Type: text/plain Date: Sat, 16 Jan 2010 11:32:35 +0000 Message-Id: <1263641555.26654.49468.camel@ebony> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Server-Quench: da26471c-0292-11df-80b9-0022640b883e X-Report-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCdxZQATClZOTQEd DAteCiN5VAwpPBRK HVkIKg5MJUcNSQVJ NksadRtFaQNbZ1hf HGQLWlREUVx7WmF/ aAMfZQ1DY0tOQQRp VFZLR01XHAJ3AVJe BmlsNUgYdwVCentx YQhhWnhYEhArd0B5 RU8HCG0EbGV9aWFL Bl1Qd1FdbQNKfB1D blAtXHsONCtlM3Bw LC8aFBMcBw5qYB9Q SwUJZVYVSkUKGDF0 TQ0NBn0uGwUFXE0A X-Authentic-SMTP: 61633235383639.1015:706/Kp X-AuthFastPath: 255 X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.409 tagged_above=-10 required=5 tests=AWL=0.190, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201001/1641 X-Sequence-Number: 154862 On Thu, 2010-01-07 at 13:16 -0500, Robert Haas wrote: > On Sun, Dec 27, 2009 at 2:12 PM, Andres Freund wrote: > > While unlikely to cause issues two new LWLockAcquire calls use the wrong > > locking mode. > > Patch attached. > > Does it make sense to add this to the 2010-01 CommitFest so we don't > lose track of it? No. As mentioned upthread, this is not a bug. I also mentioned having a separate, related thought about this, which has already been handled. There are no further actions required on this. -- Simon Riggs www.2ndQuadrant.com