From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
In-reply-to: 
 <CADvTj4rwyPp5tQmkvnP6ZEEE=ySZWEhuEbdCCDiHUqMPFtRvEw@mail.gmail.com>
References: <20201120003314.20560-1-james.hilliard1@gmail.com>
 <1256728.1605832823@sss.pgh.pa.us>
 <CADvTj4pTDEvpK3s5be6RZHs7yeRmpoCMjWKaZdjCFCce_K+1eQ@mail.gmail.com>
 <1257704.1605834289@sss.pgh.pa.us>
 <CADvTj4rUUeonoofadhhBo9b9TV3DDqQEg9n1NOfWP4V80PqK4Q@mail.gmail.com>
 <1260724.1605838811@sss.pgh.pa.us> <1261863.1605840532@sss.pgh.pa.us>
 <CADvTj4rwyPp5tQmkvnP6ZEEE=ySZWEhuEbdCCDiHUqMPFtRvEw@mail.gmail.com>
Comments: In-reply-to James Hilliard <james.hilliard1@gmail.com>
	message dated "Thu, 19 Nov 2020 20:22:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1264818.1605844933.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 19 Nov 2020 23:02:13 -0500
Message-ID: <1264819.1605844933@sss.pgh.pa.us>
Precedence: bulk

James Hilliard <james.hilliard1@gmail.com> writes:
> On Thu, Nov 19, 2020 at 7:48 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Oh, scratch that, I fat-fingered the experiment somehow.  The issue
>> is still there.  Still, I'm hesitant to apply the fix you suggest,
>> because of the law of unintended consequences.  In particular, I'm
>> afraid that using -isysroot in the link step might result in executable=
s
>> that are bound to that sysroot and will not work if it's not there
>> --- thus causing a problem for packagers trying to distribute PG
>> to non-developers.

> Since apple doesn't actually put real dylib's in the SDK path I think
> we're fine:
> $ find /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platf=
orm/Developer/SDKs/MacOSX11.0.sdk
> -name "*.dylib"

True.  Also, while actual documentation on -isysroot seems to be damn
near nonexistent, all the example usages I can find on the net appear
to put it into both compile and link steps.  So maybe we're just doing
it wrong and happened to get away with that this long.

> This seems to be a longstanding issue, I expect they don't care much abo=
ut
> autotools compared with their normal Xcode project build system. So prob=
ably
> better to just give this a try and see how it goes as it's likely to
> keep popping up otherwise.

Yeah, the one saving grace here is that, unlike the last time, we're not
hard up against a release deadline.  If we push this now we can hope to
get a fair amount of testing from PG developers before we have to ship
it.

			regards, tom lane