Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 444DB6327E4 for ; Tue, 23 Feb 2010 19:24:23 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 68578-08; Tue, 23 Feb 2010 23:24:12 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail136033.authsmtp.net (outmail136033.authsmtp.net [62.13.136.33]) by mail.postgresql.org (Postfix) with ESMTP id 85F5F6324D2; Tue, 23 Feb 2010 19:24:11 -0400 (AST) Received: from mail-c187.authsmtp.com (mail-c187.authsmtp.com [62.13.128.33]) by punt3.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id o1NNO97t057153; Tue, 23 Feb 2010 23:24:09 GMT Received: from [192.168.0.2] (88-110-213-69.dynamic.dsl.as9105.com [88.110.213.69]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id o1NNO6jT003488; Tue, 23 Feb 2010 23:24:07 GMT Subject: Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter. From: Simon Riggs To: Heikki Linnakangas Cc: pgsql-hackers@postgresql.org In-Reply-To: <20100222114730.ADEC37541D0@cvs.postgresql.org> References: <20100222114730.ADEC37541D0@cvs.postgresql.org> Content-Type: text/plain Date: Tue, 23 Feb 2010 23:24:06 +0000 Message-Id: <1266967446.3752.4843.camel@ebony> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit X-Server-Quench: 89f91b6c-20d2-11df-ab46-001185d377ca X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCdxZQATClZOTQEd DAteCiN5VAwpPBRK HVkIKg5MJUcNSQVJ NksadBtFagZba1xT HGQLWlREUl57W2d/ aw0fZQ1DY0tOQQdr U1ZPS01XHAJ3AVJe B2BgLR8oEwVGe3p4 bQhhXHZZEkxzI098 EEgHCG8GMWV9aWFL Bl0JJQdSbQNKfx5N bwR8U3ReMCtlM3Bw LCQUGhUQAQlyEh9g ChkCNksWEw4uGSAx DxwFFigqEEsZTjky KBpuLVBUFUIVel8/ Olw/VEgJdRQVDAM8 V0ZVHC5eIREdQGIi RQVXQgYVEDRFXSpG RHVV X-Authentic-SMTP: 61633235383639.1000:706/Kp X-AuthFastPath: 255 X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201002/1904 X-Sequence-Number: 158247 On Mon, 2010-02-22 at 11:47 +0000, Heikki Linnakangas wrote: > Log Message: > ----------- > Move documentation of all recovery.conf option to a new chapter. > They used to be scattered between the "backup and restore" and "streaming > replication" chapters. It's just taken me 15 minutes to locate the settings for primary_conninfo to better understand Stefan's recent post. The commit referred to here is an extremely bad change. If you intended this to be a heading within the "High Availability" chapter then I would agree. This is what I thought you had done. Having Streaming Rep described in HA and then describing the parameters that make it work in a separate chapter is ridiculous. Plus, wherever they are, they need cross references between them. This is the last straw for me. The Streaming Rep docs are now truly appalling. They were thin before, but tieing them in knots and splitting them into disconnected pieces is just too much. If I can't find the damn things, we've gone too far. SR is a big feature and deserves proper docs. -- Simon Riggs www.2ndQuadrant.com