Subject: Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf
	option to a new chapter.
From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
In-Reply-To: <4B84C783.2090408@enterprisedb.com>
References: <20100222114730.ADEC37541D0@cvs.postgresql.org>
	<1266967446.3752.4843.camel@ebony> <4B84C783.2090408@enterprisedb.com>
Content-Type: text/plain
Date: Wed, 24 Feb 2010 07:31:25 +0000
Message-Id: <1266996685.3752.5825.camel@ebony>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Wed, 2010-02-24 at 08:30 +0200, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > On Mon, 2010-02-22 at 11:47 +0000, Heikki Linnakangas wrote:
> >> Log Message:
> >> -----------
> >> Move documentation of all recovery.conf option to a new chapter.
> >> They used to be scattered between the "backup and restore" and "streaming
> >> replication" chapters.
> > 
> > It's just taken me 15 minutes to locate the settings for
> > primary_conninfo to better understand Stefan's recent post.
> > 
> > The commit referred to here is an extremely bad change.
> > 
> > If you intended this to be a heading within the "High Availability"
> > chapter then I would agree. This is what I thought you had done.
> 
> The idea was to have one chapter that describes all the options in
> recovery.conf. Some of them are specific to streaming replication
> (primary_conninfo), some are specific to PITR (recovery_target_*), some
> are common (restore_command, restore_end_command). We need a reference
> page to list them all.

We need a section, not a new chapter, if at all. A chapter on its own
for this makes no sense at all. The new section should either be in the
Backup, HA or Server Config chapters.

Please revert the change to create a new chapter.

-- 
 Simon Riggs           www.2ndQuadrant.com