Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKVhP-0000Bu-4h for pgsql-hackers@arkaria.postgresql.org; Sun, 20 May 2018 21:17:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fKVhM-0000FE-Lu for pgsql-hackers@arkaria.postgresql.org; Sun, 20 May 2018 21:17:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKVhM-0000F4-F3 for pgsql-hackers@lists.postgresql.org; Sun, 20 May 2018 21:17:00 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKVhG-0001fU-MI for pgsql-hackers@postgresql.org; Sun, 20 May 2018 21:16:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w4KLGjYF012747; Sun, 20 May 2018 17:16:46 -0400 From: Tom Lane To: "David G. Johnston" cc: Peter Geoghegan , Vik Fearing , Andrew Gierth , PostgreSQL Hackers Subject: Re: Fix for FETCH FIRST syntax problems In-reply-to: References: <877enz476l.fsf@news-spur.riddles.org.uk> <22981.1526770675@sss.pgh.pa.us> <03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com> <25267.1526773270@sss.pgh.pa.us> Comments: In-reply-to "David G. Johnston" message dated "Sun, 20 May 2018 13:38:18 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <12745.1526851005.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Sun, 20 May 2018 17:16:45 -0400 Message-ID: <12746.1526851005@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk "David G. Johnston" writes: > ​The risk here is significantly reduced since the existing user-visible > behavior is an error which presumably no one is relying upon. Between that > and being able to conform to the standard syntax for a long-standing > feature I would say the benefit outweighs the cost and risk. The risk you're ignoring is that this patch will break something that *did* work before. Given that the first version did exactly that, I do not think that risk should be considered negligible. I'm going to change my vote for back-patching from -0.5 to -1. regards, tom lane