Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kfzSb-0002h2-L1
	for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Nov 2020 05:59:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kfzSZ-0006dx-Cm
	for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Nov 2020 05:59:51 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kfzSZ-0006dq-6A
	for pgsql-hackers@lists.postgresql.org; Fri, 20 Nov 2020 05:59:51 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kfzSW-0003SI-SQ
	for pgsql-hackers@lists.postgresql.org; Fri, 20 Nov 2020 05:59:50 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0AK5xlGM1275897;
	Fri, 20 Nov 2020 00:59:47 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
In-reply-to: 
 <CADvTj4rUnisadrUpNWWp7vQCxURt81pBaTpWw=s-RadLmfjZ_w@mail.gmail.com>
References: <20201120003314.20560-1-james.hilliard1@gmail.com>
 <1256728.1605832823@sss.pgh.pa.us>
 <CADvTj4pTDEvpK3s5be6RZHs7yeRmpoCMjWKaZdjCFCce_K+1eQ@mail.gmail.com>
 <1257704.1605834289@sss.pgh.pa.us>
 <CADvTj4rUUeonoofadhhBo9b9TV3DDqQEg9n1NOfWP4V80PqK4Q@mail.gmail.com>
 <1260724.1605838811@sss.pgh.pa.us> <1261863.1605840532@sss.pgh.pa.us>
 <CADvTj4rwyPp5tQmkvnP6ZEEE=ySZWEhuEbdCCDiHUqMPFtRvEw@mail.gmail.com>
 <1264819.1605844933@sss.pgh.pa.us>
 <CADvTj4rUnisadrUpNWWp7vQCxURt81pBaTpWw=s-RadLmfjZ_w@mail.gmail.com>
Comments: In-reply-to James Hilliard <james.hilliard1@gmail.com>
	message dated "Thu, 19 Nov 2020 21:13:00 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1275895.1605851987.1@sss.pgh.pa.us>
Date: Fri, 20 Nov 2020 00:59:47 -0500
Message-ID: <1275896.1605851987@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

James Hilliard <james.hilliard1@gmail.com> writes:
> On Thu, Nov 19, 2020 at 9:02 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> True.  Also, while actual documentation on -isysroot seems to be damn
>> near nonexistent, all the example usages I can find on the net appear
>> to put it into both compile and link steps.  So maybe we're just doing
>> it wrong and happened to get away with that this long.

> Yeah, pretty sure that's what happened from what I'm seeing.

My buildfarm critters seem to be OK with this, so pushed.

			regards, tom lane