Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN3JN-0006xo-E7 for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Feb 2022 01:52:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nN3JM-0005zq-5o for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Feb 2022 01:52:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN3JL-0005zh-TK for pgsql-hackers@lists.postgresql.org; Thu, 24 Feb 2022 01:52:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN3JH-0003Jt-AG for pgsql-hackers@postgresql.org; Thu, 24 Feb 2022 01:52:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21O1qf6X1276237; Wed, 23 Feb 2022 20:52:41 -0500 From: Tom Lane To: Peter Eisentraut cc: Andres Freund , pgsql-hackers@postgresql.org Subject: Re: convert libpq uri-regress tests to tap test In-reply-to: <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com> References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de> <1261838.1645657117@sss.pgh.pa.us> <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Thu, 24 Feb 2022 00:21:36 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1276234.1645667561.1@sss.pgh.pa.us> Date: Wed, 23 Feb 2022 20:52:41 -0500 Message-ID: <1276236.1645667561@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 23.02.22 23:58, Tom Lane wrote: >> Peter Eisentraut writes: >>> libpq TAP tests should be in src/interfaces/libpq/t/. >> That's failing to account for the fact that a libpq test can't >> really be a pure-perl TAP test; you need some C code to drive the >> library. > Such things could be put under src/interfaces/libpq/test, or some other > subdirectory. We already have src/interfaces/ecpg/test. OK, but then the TAP scripts are under src/interfaces/libpq/test/t, which isn't what you said. I have no great objection to moving src/test/modules/libpq_pipeline/ to src/interfaces/libpq/test/, though, as long as the buildfarm will cope. regards, tom lane