From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        hlinnaka <hlinnaka@iki.fi>
Subject: Re: SerializeParamList vs machines with strict alignment
In-reply-to: 
 <CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>
References: <11629.1536550032@sss.pgh.pa.us>
 <CAA4eK1JfEc=cqiUiRvUcHYCf=PVEwM_bZ_QiOMHpqGpUMdY8gA@mail.gmail.com>
 <8352.1536586500@sss.pgh.pa.us>
 <CAA4eK1KTsNC--yPBatOiLJriBfGNgb_vmTF40JcEeZPedcL9YA@mail.gmail.com>
 <CAA4eK1KjGVrbMxaoE=tr1uR7mfpVLYui60tO4ANkQQAV+c+Y_A@mail.gmail.com>
 <27748.1538425312@sss.pgh.pa.us> <28627.1538426947@sss.pgh.pa.us>
 <CAEepm=1QkD_udoP3sxc_fci7x3PXQu3-Q-E-oempRuciSNp05Q@mail.gmail.com>
 <4694.1538438514@sss.pgh.pa.us>
 <CAA4eK1JYfe-Sxi3RjjBTnf1y1d-TNK+9nt1-cLajBuaXnJM+8A@mail.gmail.com>
 <8134.1538444333@sss.pgh.pa.us>
 <CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Tue, 02 Oct 2018 09:12:59 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12776.1538452350.1@sss.pgh.pa.us>
Date: Mon, 01 Oct 2018 23:52:30 -0400
Message-ID: <12777.1538452350@sss.pgh.pa.us>
Precedence: bulk

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Oct 2, 2018 at 7:08 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Also, I believe
>> that coding the test this way makes the leader send the param values to
>> multiple workers, which would flush out any problems with serializing a
>> value multiple times.  As against that, there's a hazard that the number
>> of workers might not be stable ...

> Yeah, I was actually more worried about instability part, but now I
> have tested it on both windows and centos machine and the test passes,
> so I am okay with that.  However, I feel if we want to go with that,
> there is actually no need of statement "SET force_parallel_mode=1".

OK, I hadn't tested to see if that could be dropped, but if it can,
then we don't need it.  The EXPLAIN is enough to ensure that the
test is doing what we want.  (I think we could drop the savepoint
too, no?)

			regards, tom lane