From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        David Rowley <dgrowleyml@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
In-reply-to: <20220711222758.3bdgprqvvjwndn7k@awork3.anarazel.de>
References: <815831.1657494597@sss.pgh.pa.us>
 <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com>
 <1116889.1657553859@sss.pgh.pa.us> <1201553.1657562258@sss.pgh.pa.us>
 <CA+TgmoagVZJdt-pyNw-UK_YzrrFPGtT4oQ1LtbCeCSuAk8y0UQ@mail.gmail.com>
 <1229446.1657569262@sss.pgh.pa.us>
 <20220711201755.x5hmdailt63z2xo2@awork3.anarazel.de>
 <1239476.1657571885@sss.pgh.pa.us>
 <20220711213755.gwcysmuypke3wckg@awork3.anarazel.de>
 <1261926.1657577355@sss.pgh.pa.us>
 <20220711222758.3bdgprqvvjwndn7k@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 11 Jul 2022 15:27:58 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1282696.1657579184.1@sss.pgh.pa.us>
Date: Mon, 11 Jul 2022 18:39:44 -0400
Message-ID: <1282697.1657579184@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1282697.1657579184%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I'm not entirely sure how well either the existing or the sketch above works
> when doing a VPATH build using tarball sources, and updating the files.

Seems like an awful lot of effort to avoid having multiple copies
of the file list.  I think we should just do what I sketched earlier,
ie put the master list into gen_node_support.pl and have it cross-check
that against its command line.  If the meson system can avoid having
its own copy of the list, great; but I don't feel like we have to make
that happen for the makefiles or Solution.pm.

			regards, tom lane