From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Michael Paquier <michael@paquier.xyz>,
        Jacob Champion <pchampion@vmware.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <20210703214658.GA2421985@rfd.leadboat.com>
References: <202107021459.7c2dkzyg5lua@alvherre.pgsql>
 <819502.1625239217@sss.pgh.pa.us> <20210703001639.GB2374652@rfd.leadboat.com>
 <1231771.1625321413@sss.pgh.pa.us> <1233492.1625323559@sss.pgh.pa.us>
 <20210703214658.GA2421985@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 03 Jul 2021 14:46:58 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1288323.1625352260.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 03 Jul 2021 18:44:20 -0400
Message-ID: <1288324.1625352260@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1288324.1625352260%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Sat, Jul 03, 2021 at 10:45:59AM -0400, Tom Lane wrote:
>> What I'm now thinking about is restricting the test to only be run on
>> platforms where use of foo.a libraries is deprecated, so that we can
>> be pretty sure that we won't hit this situation.  Even if we only
>> run the test on Linux, that'd be plenty to catch any mistakes.

> Hmm.  Static libraries are the rarer case on both AIX and Linux, but I'm=
 not
> aware of a relevant deprecation on either platform.  If it comes this to=
, I'd
> be more inclined to control the Makefile rule with an environment variab=
le
> (e.g. ENFORCE_LIBC_CALL_RESTRICTIONS) instead of reacting to the platfor=
m.

That'd require buildfarm owner intervention, as well as intervention
by users.  Which seems like exporting our problems onto them.  I'd
really rather not go that way if we can avoid it.

			regards, tom lane