Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujPs5-007MYA-OG for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Aug 2025 22:11:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ujPs4-00CSy0-Iv for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Aug 2025 22:11:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujPs4-00CSxr-9B for pgsql-hackers@lists.postgresql.org; Tue, 05 Aug 2025 22:11:00 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ujPs1-000ws9-1v for pgsql-hackers@postgresql.org; Tue, 05 Aug 2025 22:10:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 575MAsue1290108; Tue, 5 Aug 2025 18:10:54 -0400 From: Tom Lane To: =?utf-8?Q?=C3=81lvaro?= Herrera cc: Nathan Bossart , pgsql-hackers@postgresql.org Subject: Re: fix ancient typo in transformRelOptions() In-reply-to: <202508052156.d7n5jjro3jne@alvherre.pgsql> References: <202508052156.d7n5jjro3jne@alvherre.pgsql> Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera message dated "Tue, 05 Aug 2025 23:56:17 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1290106.1754431854.1@sss.pgh.pa.us> Date: Tue, 05 Aug 2025 18:10:54 -0400 Message-ID: <1290107.1754431854@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk =?utf-8?Q?=C3=81lvaro?= Herrera writes: > On 2025-Aug-05, Nathan Bossart wrote: >> I noticed that this function has a "namspace" parameter. The attached >> patch adds the missing 'e'. > I have vague recollections of it being this way because of "namespace" > being a C++ keyword. (commit is 3a5b77371522, but I don't have energy > to look for the discussion right now.) Oh, duh -- if you try cpluspluscheck you'll find it's unhappy. I didn't locate the discussion of "namspace" either, but I did notice that de160e2c0 used "nameSpace" for the same purpose. Maybe we should standardize on that? It looks less like a typo than "namspace", for sure. regards, tom lane