Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 349CE1337B83 for ; Thu, 2 Dec 2010 17:13:00 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 10492-07 for ; Thu, 2 Dec 2010 21:12:53 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from spinlock.commandprompt.com (host-215.commandprompt.net [207.173.203.215]) by mail.postgresql.org (Postfix) with ESMTP id 16E351337B94 for ; Thu, 2 Dec 2010 17:12:52 -0400 (AST) Received: from localhost (localhost [127.0.0.1]) by spinlock.commandprompt.com (Postfix) with ESMTP id CB2F0348024; Thu, 2 Dec 2010 13:12:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at commandprompt.com Received: from spinlock.commandprompt.com ([127.0.0.1]) by localhost (spinlock.commandprompt.com.commandprompt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrOJvoXkFtCa; Thu, 2 Dec 2010 13:12:44 -0800 (PST) Received: from perhan.alvh.no-ip.org (unknown [190.95.22.225]) by spinlock.commandprompt.com (Postfix) with ESMTPSA id 435D3348023; Thu, 2 Dec 2010 13:12:44 -0800 (PST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 4CF306E46C; Thu, 2 Dec 2010 18:12:41 -0300 (CLST) Content-Type: text/plain; charset=UTF-8 Cc: Joachim Wieland , Tom Lane , =?utf-8?q?Jos=C3=A9_Arthur_Benetasso_Villanova?= , pgsql-hackers Subject: Re: directory archive format for pg_dump From: Alvaro Herrera To: Heikki Linnakangas In-reply-to: <4CF7F8FB.1040305@enterprisedb.com> References: <4CEA9F29.5060106@enterprisedb.com> <28890.1290445623@sss.pgh.pa.us> <4CEAD61A.6060207@enterprisedb.com> <4CF40B5F.1010407@enterprisedb.com> <4CF655A3.4090308@enterprisedb.com> <4CF6562E.60506@enterprisedb.com> <4CF74F99.4050008@enterprisedb.com> <4CF7F8FB.1040305@enterprisedb.com> Date: Thu, 02 Dec 2010 18:12:41 -0300 Message-Id: <1291324036-sup-7776@alvh.no-ip.org> User-Agent: Sup/git Content-Transfer-Encoding: 8bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201012/187 X-Sequence-Number: 175449 Excerpts from Heikki Linnakangas's message of jue dic 02 16:52:27 -0300 2010: > Ok, committed, with some small cleanup since the last patch I posted. I think the comments on _ReadBuf and friends need to be updated, since they are not just for headers and TOC stuff anymore. I'm not sure if they were already outdated before your patch ... -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support