From: Antonin Houska <ah@cybertec.at>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-hackers@postgresql.org
Subject: Re: Attempt to consolidate reading of XLOG page
In-reply-to: <20190412042746.GJ2144@paquier.xyz>
References: <14984.1554998742@spoje.net>
 <20190412.122711.158276916.horiguchi.kyotaro@lab.ntt.co.jp>
 <20190412042746.GJ2144@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
   message dated "Fri, 12 Apr 2019 13:27:46 +0900."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12959.1555318127.1@localhost>
Date: Mon, 15 Apr 2019 10:48:47 +0200
Message-ID: <12960.1555318127@localhost>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> wrote:

> On Fri, Apr 12, 2019 at 12:27:11PM +0900, Kyotaro HORIGUCHI wrote:
> > This patch changes XLogRead to allow using other than
> > BasicOpenFile to open a segment, and use XLogReaderState.private
> > to hold a new struct XLogReadPos for the segment reader. The new
> > struct is heavily duplicated with XLogReaderState and I'm not
> > sure the rason why the XLogReadPos is needed.
> > Any other opinions, or thoughts?
> 
> The focus is on the stability of v12 for the next couple of months, so
> please make sure to register it to the next CF if you want feedback.

ok, will do. (A link to mailing list is needed for the CF entry, so I had to
post something anyway :-) Since I don't introduce any kind of "cool new
feature" here, I believe it did not disturb much.)

> Here are some basic thoughts after a very quick lookup.
> ...

Thanks.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com