Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iTwHq-00011g-8k
	for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Nov 2019 23:06:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1iTwHo-0001BQ-V5
	for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Nov 2019 23:06:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iTwHo-0001BJ-MZ
	for pgsql-hackers@lists.postgresql.org; Sun, 10 Nov 2019 23:06:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iTwHm-0003WH-4s
	for pgsql-hackers@lists.postgresql.org; Sun, 10 Nov 2019 23:06:24 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xAAN6I4Y012988;
	Sun, 10 Nov 2019 18:06:18 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
In-reply-to: <63DE9A1C-5F59-47AF-90C9-26A7EF9897B3@yesql.se>
References: <31473.1573412838@sss.pgh.pa.us>
 <124042D9-F307-402A-80ED-395C154858BA@yesql.se>
 <4978.1573420358@sss.pgh.pa.us>
 <63DE9A1C-5F59-47AF-90C9-26A7EF9897B3@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Sun, 10 Nov 2019 23:39:14 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12986.1573427177.1@sss.pgh.pa.us>
Date: Sun, 10 Nov 2019 18:06:17 -0500
Message-ID: <12987.1573427177@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Applies, builds clean and passes light testing.

Thanks for checking!

> I can see the appeal of
> including it before the wrap, even though I personally would've held off.

Nah, I'm not gonna risk it at this stage.  I concur with your point
that this is an ancient bug, and one that is unlikely to bite many
people.  I'll push it Wednesday or so.

			regards, tom lane