Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 6BB9E1337999 for ; Mon, 7 Mar 2011 05:30:48 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 56891-01 for ; Mon, 7 Mar 2011 09:30:41 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail149080.authsmtp.com (outmail149080.authsmtp.com [62.13.149.80]) by mail.postgresql.org (Postfix) with ESMTP id 8E006133616B for ; Mon, 7 Mar 2011 05:30:40 -0400 (AST) Received: from mail-c194.authsmtp.com (mail-c194.authsmtp.com [62.13.128.121]) by punt10.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id p279UcXg067464; Mon, 7 Mar 2011 09:30:38 GMT Received: from [192.168.0.3] ([81.5.146.37]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2) with ESMTP id p279UaeA053358; Mon, 7 Mar 2011 09:30:36 GMT Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication. From: Simon Riggs To: Fujii Masao Cc: PostgreSQL-development In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Mar 2011 09:30:35 +0000 Message-ID: <1299490235.1696.7973.camel@ebony> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit X-Server-Quench: 8f11bbff-489d-11e0-80b9-0022640b883e X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCdxZQATClZOTQEd DAteCiN5VAwpPBRK HVkIKg5MJUcNSQVJ NksadBtFaAJbYFhD HGQLWlVEUFR7WmN/ aAwfZQRDZ1RPWwN0 U09WR1pVCwUmQR4G D3tPB2hycgZFfXY+ Z0FjXD5TCkV7JxQr FFNQHWRSeGZhPWAC WEAKfh5UcAFIeBtF OFh3VyZDAzANdhET OCoWHgwNEA9kHWxN TRoUKQBabEgFHzU9 ShYeVSk1FEseTi4v Lhsgb1UbGloLNUE2 PFdDEUkJNRQSEApY GFxWSDVUP10ATCM3 DARcGyYA X-Authentic-SMTP: 61633235383639.1015:706 X-AuthFastPath: 0 (Was 255) X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=1.719 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FS_REPLICA=3.599, RCVD_IN_DNSWL_LOW=-0.7, SARE_SPEC_REPLICA=0.72 X-Spam-Level: * X-Archive-Number: 201103/446 X-Sequence-Number: 183696 On Mon, 2011-03-07 at 17:44 +0900, Fujii Masao wrote: > The above check should be required also after pg_ctl reload since > synchronous_standby_names can be changed by SIGHUP? > Or how about just removing that? If the patch I submitted is > committed,empty synchronous_standby_names and max_wal_senders = 0 > settings is no longer unsafe. Ah, on reload. I plugged the gap only at startup. I'll fix by changing assign_synchronous_standby_names(), not by changing lots of other parts of code and making runtime check each COMMIT. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services