Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6yvL-003SXD-1v for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Nov 2023 20:06:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r6yvJ-004gXw-GL for pgsql-hackers@arkaria.postgresql.org; Sat, 25 Nov 2023 20:06:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6yvJ-004gXn-6D for pgsql-hackers@lists.postgresql.org; Sat, 25 Nov 2023 20:06:41 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r6yvF-008VQh-Oa for pgsql-hackers@postgresql.org; Sat, 25 Nov 2023 20:06:39 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50aaaf6e58fso4533495e87.2 for ; Sat, 25 Nov 2023 12:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1700942795; x=1701547595; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rz3zolJiNhNq93L2loCYA1x5llXZFcLm7NncJoMgz5A=; b=X4sj8lEjM4HO8/YsYdIQh/Ay0CifZ0yKzidyo9qxweA7oqenuVCvvutquXDyyrTUt8 nOpmFfqMKZcJ0cfyaAFserODakr7hPIQr6+1Sgw+c0z7mL2BzpDjk1uPi59Xi0CCs4qt 31vszCjBNmnVKjTcFuIDZHk7BqkSfYGaa2Y/Rl8pPHsVel1vdhW2M12eA8nU+Sfi/l5U 1Kr6d+7RnAchM+wRJ6BWNronsl7aNt0WoVNUWMy0HI0nO14r6+38iPok1l4PjXB8BXfp rJWUaIcLLRloHMObsEOGsZTSziKRLiv63nK7vuKDkfQDGB77pg+ne67t665s8yAfjlC1 o4eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700942795; x=1701547595; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rz3zolJiNhNq93L2loCYA1x5llXZFcLm7NncJoMgz5A=; b=QGJ4TwM3IlPp+YkObllE4E1lGiPAe9TMktlemuplyf233s/VOSAlUPAfG4AhuYtYoE UITkNbQd2Yq7qPPJyWrpoatZhch59+cpUqWUH8gRiPHnKdmL1tkTmhwVTrJvvCn8wbnz mCZpZWx57dfEm/FWgcRGo3lVgpVreGbkke5Pxs+t92saXsvDRHkDXwcUnMw5V5BcILYg 7AxueOwuESUJa+orOx2pSSjnawKR+ZhuIacyCGKmmXM5/bUA4BRieToQUlvv3fBCsvfP XGAjKSUDm2pCjiFM6KzhDqrl/vGLSYPk+JKtzFRd5vIQSCrjMTuMQDc+D3xZWJM6H+2k ZpFg== X-Gm-Message-State: AOJu0YwhT0fnmVNSjuyPuGK+ivdwnpMEc9KjuWIKfcovSj5f8O/RXbPU FkHKZ76BQRPxiaV5dj4/KvIOEipZQkskarUltu4= X-Google-Smtp-Source: AGHT+IGWb6Z3U3E+pURvNZ+jcTmxPWijquiP4kMvSePEUUpLRCpEwzI5J5oWakVnPjBPear5wU7B0w== X-Received: by 2002:ac2:4283:0:b0:50a:a9ec:1897 with SMTP id m3-20020ac24283000000b0050aa9ec1897mr4941357lfh.35.1700942765323; Sat, 25 Nov 2023 12:06:05 -0800 (PST) Received: from [10.137.0.17] (ip-86-49-229-30.bb.vodafone.cz. [86.49.229.30]) by smtp.gmail.com with ESMTPSA id bk21-20020a170906b0d500b00a0451802b3csm3844918ejb.4.2023.11.25.12.06.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Nov 2023 12:06:04 -0800 (PST) Message-ID: <12d42882-7860-9b46-7572-3b2fae6c916f@enterprisedb.com> Date: Sat, 25 Nov 2023 21:06:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: brininsert optimization opportunity To: Soumyadeep Chakraborty , Matthias van de Meent Cc: Alvaro Herrera , pgsql-hackers , Ashwin Agrawal References: <20230704112358.bkm6r3fxp275m4lu@alvherre.pgsql> <2b672382-c0b3-3f44-b72c-86b1077b082b@enterprisedb.com> <11f78627-a934-1f8b-084e-21ed95f2564c@enterprisedb.com> <35e7be37-0d35-d8ea-a4d5-eff84aefcc39@enterprisedb.com> <1d68ef1d-41c5-7159-c6c0-b44dad4e3148@enterprisedb.com> Content-Language: en-US From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I've done a bit more cleanup on the last version of the patch (renamed the fields to start with bis_ as agreed, rephrased the comments / docs / commit message a bit) and pushed. Thanks for the patch! -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company