Subject: Re: [PATCH] Generic type subscripting
To: Dmitry Dolgov <9erthalion6@gmail.com>
References: 
 <CA+q6zcVovR+XY4mfk-7oNk-rF91gH0PebnNfuUjuuDsyHjOcVA@mail.gmail.com>
 <20423.1489533013@sss.pgh.pa.us>
 <393cd0ae-5b84-849e-fc73-7077470a009e@pgmasters.net>
 <CA+q6zcUX=Om75kgZXkpYPhnwUCo4osFpzd83dKPzjSGfCmxEgA@mail.gmail.com>
 <65df4a65-a9d8-3531-5baf-edb237771f0e@pgmasters.net>
 <22355.1490369372@sss.pgh.pa.us>
 <449f42b9-f338-9e45-cb33-3e15c7b547ad@postgrespro.ru>
 <CA+q6zcWFLpEX6H1LOOKFJMAN+LB+mmEx=6Syd4WVioXkbXq32A@mail.gmail.com>
 <c7cc0592-4c9b-699d-3b61-810804759de6@postgrespro.ru>
 <CA+q6zcXQ9UO0_qGqoFgd_4ymKYxwr-3he+abEbnWaPk2nbmPVQ@mail.gmail.com>
 <CA+q6zcXsonX+qLhf2crQgj14NzJmcibABhyVch1kjNtSL1+V1A@mail.gmail.com>
 <CAKNkYnzpMwx0KtLCaOoFVGQZoJHJ5E+mTrZGEcary0eKu2LdLg@mail.gmail.com>
 <CA+q6zcWVDF5Y8+FNQoV1vOmA9zCt4TiCqpHmDP3grP6v2mE30A@mail.gmail.com>
 <f65bee8c-34b8-178c-2ff2-28b2cfb7de4f@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Steele <david@pgmasters.net>,
 peter.eisentraut@2ndquadrant.com,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
Message-ID: <12d8e0d0-e0ed-2846-cb8b-431f17e7d8c7@postgrespro.ru>
Date: Wed, 5 Apr 2017 17:33:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <f65bee8c-34b8-178c-2ff2-28b2cfb7de4f@postgrespro.ru>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 05.04.2017 16:06, Arthur Zakirov wrote:
> On 04.04.2017 15:41, Dmitry Dolgov wrote:
>> Sorry for late reply. Here is a new version of the patch, I rebased it
>> and
>> fixed those issues you've mentioned (pretty nasty problems, thank you for
>> noticing).
>
> Thank you!
>
> I've looked at the patch again.
>

Sorry maybe it's too naive. Also I was wondering.

> +	element_type_id = transformArrayType(&array_type, &array_typ_mode);
> +	sbsref->refelemtype = element_type_id;

I don't understand this part of the patch. Why is it necessary to 
execute transformArrayType() second time? It was executed in 
transformContainerSubscripts().

> +	if (!OidIsValid(elementType))
> +		elementType = containerType;

This part looks strange to me too.

It this parts are necessary it would be good to add comments.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers