Subject: Re: Remove line length restriction in passwordFromFile()
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Fujii Masao <fujii@postgresql.org>
References: <4187382.1598909041@sss.pgh.pa.us>
 <90aed8c6-a171-4cf7-4e4a-0d4d9593f6c5@oss.nttdata.com>
 <b2391bb7-33c5-a25e-e99a-81f7e96efdad@oss.nttdata.com>
 <54742.1598973287@sss.pgh.pa.us>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <12eff40e-80df-244e-86b8-c60b0e88bc75@oss.nttdata.com>
Date: Thu, 10 Sep 2020 01:34:48 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <54742.1598973287@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/09/02 0:14, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> The patch looks good to me, except the following minor thing.
>> +		if (fgets(buf.data + buf.len, buf.maxlen - buf.len - 1, fp) == NULL)
>> IIUC fgets() reads the data with the specified size - 1, so ISTM that -1 of
>> "buf.maxlen - buf.len - 1" is not necessary.
> 
> Good point, I was being unduly conservative.  Thanks for reviewing
> the patch!

Thanks for committing the patch!

The patch was back-patched to v13, but v13 release note still has the following item.

     Tighten libpq's overlength-line handling and comment detection for .pgpass files (Fujii Masao)

This should be changed to the following or something?

     Teach libpq to handle arbitrary-length lines in .pgpass files (Tom Lane)

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION