Message-ID: <12facb9f-541b-5a5c-040e-a5ca3c1dd4a3@enterprisedb.com>
Date: Thu, 3 Feb 2022 11:54:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.1
Subject: Re: UNIQUE null treatment option
Content-Language: en-US
To: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, pgsql-hackers <pgsql-hackers@postgresql.org>
References: <84e5ee1b-387e-9a54-c326-9082674bde78@enterprisedb.com>
 <ac7f9f56-acf6-dfd2-2295-56eff1bbc935@enterprisedb.com>
 <CAH2-Wz=K67yJSuF-VF+FHA7MhGdht2WohFyTmSJeFD0C9bOtSQ@mail.gmail.com>
 <87d6b906-d1cb-75c1-7f90-24b17c724369@enterprisedb.com>
 <CALT9ZEHV1uQZzLY=adSF5Bhfj3DaSLCZRmUJCSF=5F0EjV5cUw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CALT9ZEHV1uQZzLY=adSF5Bhfj3DaSLCZRmUJCSF=5F0EjV5cUw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/12facb9f-541b-5a5c-040e-a5ca3c1dd4a3%40enterprisedb.com>
Precedence: bulk

On 28.01.22 13:56, Pavel Borisov wrote:
>     Makes sense.  Here is an updated patch with this change.
> 
>     I didn't end up renaming anynullkeys.  I came up with names like
>     "anyalwaysdistinctkeys", but in the end that felt too abstract, and
>     moreover, it would require rewriting a bunch of code comments that
>     refer
>     to null values in this context.  Since as you wrote, anynullkeys is
>     just
>     a local concern between two functions, this slight inaccuracy is
>     perhaps
>     better than some highly general but unclear terminology.
> 
> Agree with that. With the comment it is clear how it works.
> 
> I've looked at the patch v3. It seems good enough for me. CFbot tests 
> have also come green.
> Suggest it is RFC now.

Committed.  Thanks.