Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kjq4G-00050z-Cc
	for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Nov 2020 20:46:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kjq4F-0006Mk-BD
	for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Nov 2020 20:46:39 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kjq4F-0006Md-4B
	for pgsql-hackers@lists.postgresql.org; Mon, 30 Nov 2020 20:46:39 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kjq4D-0006lo-54
	for pgsql-hackers@postgresql.org; Mon, 30 Nov 2020 20:46:38 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0AUKkJ0K1306039;
	Mon, 30 Nov 2020 15:46:19 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
        Stephen Frost <sfrost@snowman.net>,
        Ian Lawrence Barwick <barwick@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour
In-reply-to: <X8SYCnbcLTXUQrc7@paquier.xyz>
References: 
 <CAB8KJ=h-XALik4M7gv-pX48=+SPWexfaYwa+yTnPwD3DxceXrg@mail.gmail.com>
 <e4934710-73cb-6eef-fd35-6fcfd05f381b@iki.fi>
 <20201023134611.GG16415@tamriel.snowman.net>
 <145522.1603461363@sss.pgh.pa.us>
 <20201023141211.GH16415@tamriel.snowman.net>
 <147812.1603464663@sss.pgh.pa.us>
 <fd93f1c5-7818-a02c-01e5-1075ac0d4def@iki.fi>
 <20201025215650.GN9241@telsasoft.com>
 <ca583d26-6bcf-6081-dc72-f1fcf867e974@iki.fi>
 <20201129192748.GP24052@telsasoft.com> <X8SYCnbcLTXUQrc7@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 30 Nov 2020 15:58:18 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1306037.1606769179.1@sss.pgh.pa.us>
Date: Mon, 30 Nov 2020 15:46:19 -0500
Message-ID: <1306038.1606769179@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> So this comes down to 5 items, as per the attached.  Thoughts?

These items look fine to me, except this bit seems a bit awkward:

+     Note that the delayed indexing technique used for <acronym>GIN</acronym>
+     (see <xref linkend="gin-fast-update"/> for details) makes this advice
+     less necessary, but for very large updates it may still be best to
+     drop and recreate the index.

Less necessary than what?  Maybe instead write

      When fastupdate is enabled (see ...), the penalty is much less than
      when it is not.  But for very large updates it may still be best to
      drop and recreate the index.

			regards, tom lane