Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vnEIJ-0041Ub-1m for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Feb 2026 11:10:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vnEII-004Ys6-0c for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Feb 2026 11:10:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vnEIH-004Yry-2h for pgsql-hackers@lists.postgresql.org; Tue, 03 Feb 2026 11:10:05 +0000 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vnEIF-00000000pIX-0y7n for pgsql-hackers@postgresql.org; Tue, 03 Feb 2026 11:10:05 +0000 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-7d18c654458so2103567a34.3 for ; Tue, 03 Feb 2026 03:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770117001; x=1770721801; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2ywnUwpGtM28pLhRc1OoJdtAcPwcPJDu2BSe1fIOUb8=; b=T01czvy3xzXQxHr3JdY9x/+Wa3YfO8jo1uZ8iykSn3r2xHLRjUxeC/Su7wfA2yJ+jK 5nXxIizVsL7Ib29fFGTIuwJiQEY3lc3AVC6zhc+pbCKmBXsblECxPnm5169Ip54pfLdv LAwXTdZYapb5ZrdxQzTamoPFZLYVNLOK2gFuO8V5cC7SRoyx7FAQAJfYsaweTsE+ZXMb A2CYi8etuC5WwMmgz1kJbmGjFxK9UzooaMBDUKvKR4IcyX1c1Ged0i8h4PSFjsN5tpBF uM/WRRvU7rfLlVN8P/23iYbxThhI4VL4TuEfs08cu3yCbGEVCpgomAqlQJwqnjnO8WZK uJnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770117001; x=1770721801; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ywnUwpGtM28pLhRc1OoJdtAcPwcPJDu2BSe1fIOUb8=; b=bg/4nRcCc7lOlDPTrJb1sC1V9Xoy/FG6uzEAg5x7BOiyKUMgJ4EszW9+OWyjT2otxs H7FmOMSFO5n3pmUqjex6BzfyUkj7Z5gZ50H2axidoviWA//eAuhSf9gElORBP7uKNxCa huuiTlg2tPJxL0y8AbDGqirheuL2WLQxIMNEoomCKWJ1BfKyC+YafyZvmDW31EUl+r+D OX5nBvvGX2d/HhyskHbZFbD180pGF7gg1sS4rskuBXKhDV5fGjgZAJ2yMUattQAekb72 QRlKMkyQyMZGdm2Yr2oAwFC3V5dKFcT5phGsq4a9ub5lMr20AL8C7JMrZcVTNHjG8reK A9ow== X-Forwarded-Encrypted: i=1; AJvYcCVfprmpu7F6yr8XWRIpo7s11+/S/guUdsu6VGMTvJ9GrZYmguaYDuYOhC2kA4AOYqeO3kBzHYvaITag9lja@postgresql.org X-Gm-Message-State: AOJu0Yy3siWbQVrKOv3uuVA7+7eit2OyanaIX4w4rKTgrmo7U1J+XS2z flaC2k1CJSlcB8vR6dfDvU07yjjHw1dX8Dd8DahJFCaMeUjosbO6sEc0 X-Gm-Gg: AZuq6aL2PhcchOKPg6izpEP0TAG6vbza9ryjPIofe9NOQ5Fea9x5gqB+8VUOIYaXQBX y01t5Bv3DyGvW0m2bunwPNDiRt75A0FQ8O9xVDwHez3TZ75Ap5oxJbXsl86xZcxInmqSS639pKH AS0WZk/7a+P381sO/FtPaS+oFlZc2VgGsCDgF8AZC1VeRW4LYpwcGd46n9o4m5DAesIlNLrKAUJ n39aj3jzVBDeJoA5YJXirojWC4fRsULU8CIfz068lzsc0rHe+fd9/4L/L/MOesP/28L6BDY/oCm iHC5ewJ/tLinLXkgDhZHrXlUMr7DpLWqC5ZC+t+t/yyhl4ZpqiptO+5Bi6Gg3rTGREfI5XITizr J4Zxt2Yj27BfBQHFn0hkBGnMLiSqMzG0aj/F7f4uRs1vasQykmvfdIvK2OR+yFs5iFizeoP/Pwa /jC/bObuLWmQWUEvp1Atda0zDY8EdSZIeORx6H0wsZjHtJXylivYrXJqs= X-Received: by 2002:a05:6830:dc6:b0:7ab:e111:1a57 with SMTP id 46e09a7af769-7d1a531e462mr7417066a34.31.1770117001299; Tue, 03 Feb 2026 03:10:01 -0800 (PST) Received: from [172.31.5.233] (vip-148-139-2-229.cust.service-now.com. [148.139.2.229]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d2eb466648sm5173656a34.25.2026.02.03.03.09.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 03:10:00 -0800 (PST) Message-ID: <130682f7-e9a7-4916-8e2d-711900d8ccee@gmail.com> Date: Tue, 3 Feb 2026 12:09:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: get rid of Pointer type, mostly To: Peter Eisentraut , Chao Li Cc: Robert Haas , Tom Lane , pgsql-hackers References: <4154950a-47ae-4223-bd01-1235cc50e933@eisentraut.org> <955002.1764000569@sss.pgh.pa.us> <957744.1764002037@sss.pgh.pa.us> <970261.1764008763@sss.pgh.pa.us> <987824.1764013105@sss.pgh.pa.us> <7c7e1e59-284b-49f6-a496-17dd4170f979@gmail.com> <2b929da1-dbb5-476f-a878-899b1e9e80f2@gmail.com> <8B037F29-163E-4446-BA94-7553C9ECA0F1@gmail.com> <0d5ca69a-91c7-4efb-a53a-9948a4f32717@gmail.com> <9d4fb5e5-b1c5-4e56-865d-93ba6a390022@eisentraut.org> Content-Language: en-US From: David Geier In-Reply-To: <9d4fb5e5-b1c5-4e56-865d-93ba6a390022@eisentraut.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Peter, >> Either way is fine by me. It just seemed like the majority of commenters >> where in favor of keeping some type in the GIN code for readability. > > After further consideration, I think it is best to leave this alone as > is.  One particular problem is that Pointer is part of the documented > API of GIN, and if we either remove it or rename it, then this would > create a bunch of work for extensions to keep their code compiling > across major versions. That's a pity. It would have been a nice cleanup of some crufty code that makes readability harder than needed. Seems like a simple rename would be acceptable in the spirit of e.g. [1]. -- David Geier [1] https://www.postgresql.org/message-id/2273bc2a-045d-4a75-8584-7cd9396e5534%40eisentraut.org