Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZmNO-0003cB-P7 for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Dec 2018 00:39:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZmNL-0001xR-Gr for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Dec 2018 00:39:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZmNL-0001xD-6Q for pgsql-hackers@lists.postgresql.org; Thu, 20 Dec 2018 00:39:43 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZmNI-0002O9-3i for pgsql-hackers@postgresql.org; Thu, 20 Dec 2018 00:39:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wBK0dXol013072; Wed, 19 Dec 2018 19:39:33 -0500 From: Tom Lane To: Robert Haas cc: Andres Freund , "pgsql-hackers@postgresql.org" , Amit Kapila Subject: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()? In-reply-to: References: <20181219083945.6khtgm36mivonhva@alap3.anarazel.de> <20181219223736.4k2lhqoj34aaxj3m@alap3.anarazel.de> Comments: In-reply-to Robert Haas message dated "Wed, 19 Dec 2018 18:04:26 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13070.1545266373.1@sss.pgh.pa.us> Date: Wed, 19 Dec 2018 19:39:33 -0500 Message-ID: <13071.1545266373@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Wed, Dec 19, 2018 at 5:37 PM Andres Freund wrote: >> What's gained by the logic of emitting that warning in VACUUM after a >> crash? I don't really see any robustness advantages in it. > I don't know. I am just normally reluctant to change things > precipitously that are of long tenure. Me too, but I think Andres has a point here. Those warnings in VACUUM are ancient, probably predating the introduction of WAL :-(. At the time there was good reason to be suspicious of zeroed pages in tables. Now, though, we have (what we think is) a bulletproof crash recovery procedure in which possibly-zeroed pages are to be expected; so we're just causing users unnecessary alarm by warning about them. I think it's reasonable to, if not remove the messages entirely, at least downgrade them to a low DEBUG level. regards, tom lane