From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thunder <thunder1@126.com>
cc: "Michael Paquier" <michael@paquier.xyz>,
        "Kuntal Ghosh" <kuntalghosh.2007@gmail.com>,
        "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: PANIC :Call AbortTransaction when transaction id is no normal
In-reply-to: <4d8688e8.2ed3.16ab444bc37.Coremail.thunder1@126.com>
References: <3850b11a.5121.16aaf827e4a.Coremail.thunder1@126.com>
 <CAGz5QCJKDptF4R0xHzM9YLxbLwZHA9enW9zjOi+vF93HVycVgw@mail.gmail.com>
 <20190513081018.GC2273@paquier.xyz> <15939.1557754652@sss.pgh.pa.us>
 <20190513235336.GE2273@paquier.xyz>
 <4d8688e8.2ed3.16ab444bc37.Coremail.thunder1@126.com>
Comments: In-reply-to Thunder <thunder1@126.com>
	message dated "Tue, 14 May 2019 10:56:04 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13092.1557804531.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 13 May 2019 23:28:51 -0400
Message-ID: <13093.1557804531@sss.pgh.pa.us>
Precedence: bulk

[ please don't top-post on the PG lists ]

Thunder  <thunder1@126.com> writes:
> At 2019-05-14 07:53:36, "Michael Paquier" <michael@paquier.xyz> wrote:
>> On Mon, May 13, 2019 at 09:37:32AM -0400, Tom Lane wrote:
>>> But ... that code's been like that for decades and nobody's complained
>>> before.  Why are we worried about bootstrap's response to signals at a=
ll?

> On our server when process crash and core dump file generated we will re=
ceive complaining phone call.
> That's why i try to fix it.

OK, that's fair.  The SIG_DFL change I suggested will fix that problem
for SIGINT etc (except SIGQUIT, for which you should be *expecting*
a core file).  I agree with Michael that we do not wish to change what
happens for an internal error; but external signals do not represent
a bug in PG, so forcing a PANIC for those seems unwarranted.

			regards, tom lane