Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jKkd5-0008AU-RR
	for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2020 15:22:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jKkd4-0000Y8-Ka
	for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Apr 2020 15:22:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jKkd4-0000Y1-Df
	for pgsql-hackers@lists.postgresql.org; Sat, 04 Apr 2020 15:22:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jKkd1-0006kU-8O
	for pgsql-hackers@postgresql.org; Sat, 04 Apr 2020 15:22:37 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 034FMWw3013138;
	Sat, 4 Apr 2020 11:22:32 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: Petr Jelinek <petr@2ndquadrant.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Rafia Sabih <rafia.pghackers@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: adding partitioned tables to publications
In-reply-to: 
 <CA+HiwqGH+sh+0v9cgEnmU3qYycOJoj2Bo3D38F0hZz=4v96s5g@mail.gmail.com>
References: 
 <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
 <b8f257af-3fcd-65b9-088c-0248d82e4e99@2ndquadrant.com>
 <CA+HiwqFZbbJzAZgTjqbRarp_xeqyymuNmGg8Q5tDKTZbk3=c2A@mail.gmail.com>
 <c0d69728-c3d8-ede8-ad31-941b2bbaff66@2ndquadrant.com>
 <CA+HiwqE+6gNgr-BVYeCMT38naRi9cJaanJb7+FCNsX9XgMwHsQ@mail.gmail.com>
 <CA+HiwqFjYE5anArxvkjr37AQMd52L-LZtz9Ld2QrLQ3YfcYhTw@mail.gmail.com>
 <CA+HiwqE+z2=wLv3a41h7JopcnUZAiFPeaiQyxZeGQ62QV3vsPQ@mail.gmail.com>
 <4f999141-97c8-c968-a726-0a1ec3e36e47@2ndquadrant.com>
 <ff6007b3-02c2-8296-2896-db99a51f57e2@2ndquadrant.com>
 <CA+HiwqGWXeBA2xagkz_YdxycmO38Vah_aviyJf_kC_kjCdL-Xg@mail.gmail.com>
 <CA+HiwqGkknVb+ccLVkgw1DoBYPzpuR43L+aT1eOT8dVEtiedtw@mail.gmail.com>
 <e934a27d-bab4-b818-8936-bbcd2d41df0a@2ndquadrant.com>
 <9684.1585929105@sss.pgh.pa.us> <13925.1585977907@sss.pgh.pa.us>
 <4f5a1798-9b23-f1fd-4b9e-67d0ea503e4c@2ndquadrant.com>
 <CA+HiwqGH+sh+0v9cgEnmU3qYycOJoj2Bo3D38F0hZz=4v96s5g@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Sat, 04 Apr 2020 23:43:44 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13136.1586013752.1@sss.pgh.pa.us>
Date: Sat, 04 Apr 2020 11:22:32 -0400
Message-ID: <13137.1586013752@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> One thing to I must clarify: coverage for most of pgoutput.c looks
> okay on each run.  I am concerned that the coverage for the code added
> by the patch is shown to be close to zero, which is a mystery to me,
> because I can confirm by other means such as debugging elogs() to next
> to the new code that the newly added tests do cover them.

According to

https://coverage.postgresql.org/src/backend/replication/pgoutput/index.html

the coverage is pretty good.  Maybe you're doing something wrong
in enabling coverage testing locally?

			regards, tom lane