Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPRZB-0007Y1-4U for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Oct 2020 14:34:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kPRZA-0003go-1u for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Oct 2020 14:34:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPRZ9-0003gh-Qi for pgsql-hackers@lists.postgresql.org; Mon, 05 Oct 2020 14:34:15 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPRZ6-00055U-AX for pgsql-hackers@postgresql.org; Mon, 05 Oct 2020 14:34:15 +0000 Received: from hnk.local (sp49-97-94-178.msc.spmode.ne.jp [49.97.94.178]) by oss.nttdata.com (Postfix) with ESMTPSA id D744D60165; Mon, 5 Oct 2020 23:34:05 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module To: Bharath Rupireddy , PostgreSQL-development References: From: Fujii Masao Message-ID: <13156732-5189-af54-3d28-e2ee2a8568e0@oss.nttdata.com> Date: Mon, 5 Oct 2020 23:34:05 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------684DC038719271D441C94BFC" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------684DC038719271D441C94BFC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 2020/10/05 19:45, Bharath Rupireddy wrote: > Hi, > > Autoprewarm module is using it's own SIGHUP(apw_sigterm_handler, got_sigterm) and SIGTERM(apw_sighup_handler, got_sighup) handlers which are similar to standard signal handlers(except for a difference [1]). Isn't it good to remove them and  use standard SignalHandlerForConfigReload and SignalHandlerForShutdownRequest? > > Attaching the patch for the above changes. > > Looks like the commit[2] replaced custom handlers with standard handlers. > > Thoughts? +1 The patch looks good to me. ISTM that we can also replace StartupProcSigHupHandler() in startup.c with SignalHandlerForConfigReload() by making the startup process use the general shared latch instead of its own one. POC patch attached. Thought? Probably we can also replace sigHupHandler() in syslogger.c with SignalHandlerForConfigReload()? This would be separate patch, though. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------684DC038719271D441C94BFC Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="make_startup_use_general_shared_latch.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="make_startup_use_general_shared_latch.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYyBiL3NyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYwppbmRleCA4ZjExYjFiOWRlLi44YjQ0MzQ5 NjJmIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCkBAIC02ODIsNyArNjgyLDcg QEAgdHlwZWRlZiBzdHJ1Y3QgWExvZ0N0bERhdGEKIAkgKiBXQUwgcmVwbGF5LCBpZiBpdCBp cyB3YWl0aW5nIGZvciBXQUwgdG8gYXJyaXZlIG9yIGZhaWxvdmVyIHRyaWdnZXIgZmlsZQog CSAqIHRvIGFwcGVhci4KIAkgKi8KLQlMYXRjaAkJcmVjb3ZlcnlXYWtldXBMYXRjaDsKKwlM YXRjaAkJKnJlY292ZXJ5V2FrZXVwTGF0Y2g7CiAKIAkvKgogCSAqIER1cmluZyByZWNvdmVy eSwgd2Uga2VlcCBhIGNvcHkgb2YgdGhlIGxhdGVzdCBjaGVja3BvaW50IHJlY29yZCBoZXJl LgpAQCAtNTE4NSw3ICs1MTg1LDYgQEAgWExPR1NobWVtSW5pdCh2b2lkKQogCVNwaW5Mb2Nr SW5pdCgmWExvZ0N0bC0+SW5zZXJ0Lmluc2VydHBvc19sY2spOwogCVNwaW5Mb2NrSW5pdCgm WExvZ0N0bC0+aW5mb19sY2spOwogCVNwaW5Mb2NrSW5pdCgmWExvZ0N0bC0+dWxzbl9sY2sp OwotCUluaXRTaGFyZWRMYXRjaCgmWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCk7CiB9 CiAKIC8qCkBAIC02MTIyLDcgKzYxMjEsNyBAQCByZWNvdmVyeUFwcGx5RGVsYXkoWExvZ1Jl YWRlclN0YXRlICpyZWNvcmQpCiAKIAl3aGlsZSAodHJ1ZSkKIAl7Ci0JCVJlc2V0TGF0Y2go JlhMb2dDdGwtPnJlY292ZXJ5V2FrZXVwTGF0Y2gpOworCQlSZXNldExhdGNoKE15TGF0Y2gp OwogCiAJCS8qIG1pZ2h0IGNoYW5nZSB0aGUgdHJpZ2dlciBmaWxlJ3MgbG9jYXRpb24gKi8K IAkJSGFuZGxlU3RhcnR1cFByb2NJbnRlcnJ1cHRzKCk7CkBAIC02MTQ2LDcgKzYxNDUsNyBA QCByZWNvdmVyeUFwcGx5RGVsYXkoWExvZ1JlYWRlclN0YXRlICpyZWNvcmQpCiAJCWVsb2co REVCVUcyLCAicmVjb3ZlcnkgYXBwbHkgZGVsYXkgJWxkIHNlY29uZHMsICVkIG1pbGxpc2Vj b25kcyIsCiAJCQkgc2VjcywgbWljcm9zZWNzIC8gMTAwMCk7CiAKLQkJKHZvaWQpIFdhaXRM YXRjaCgmWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCwKKwkJKHZvaWQpIFdhaXRMYXRj aChNeUxhdGNoLAogCQkJCQkJIFdMX0xBVENIX1NFVCB8IFdMX1RJTUVPVVQgfCBXTF9FWElU X09OX1BNX0RFQVRILAogCQkJCQkJIHNlY3MgKiAxMDAwTCArIG1pY3Jvc2VjcyAvIDEwMDAs CiAJCQkJCQkgV0FJVF9FVkVOVF9SRUNPVkVSWV9BUFBMWV9ERUxBWSk7CkBAIC02NDc0LDEx ICs2NDczLDExIEBAIFN0YXJ0dXBYTE9HKHZvaWQpCiAJfQogCiAJLyoKLQkgKiBUYWtlIG93 bmVyc2hpcCBvZiB0aGUgd2FrZXVwIGxhdGNoIGlmIHdlJ3JlIGdvaW5nIHRvIHNsZWVwIGR1 cmluZwotCSAqIHJlY292ZXJ5LgorCSAqIEFkdmVydGlzZSBvdXIgbGF0Y2ggdGhhdCBvdGhl ciBwcm9jZXNzZXMgY2FuIHVzZSB0byB3YWtlIHVzIHVwCisJICogaWYgd2UncmUgZ29pbmcg dG8gc2xlZXAgZHVyaW5nIHJlY292ZXJ5LgogCSAqLwogCWlmIChBcmNoaXZlUmVjb3ZlcnlS ZXF1ZXN0ZWQpCi0JCU93bkxhdGNoKCZYTG9nQ3RsLT5yZWNvdmVyeVdha2V1cExhdGNoKTsK KwkJWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCA9ICZNeVByb2MtPnByb2NMYXRjaDsK IAogCS8qIFNldCB1cCBYTE9HIHJlYWRlciBmYWNpbGl0eSAqLwogCU1lbVNldCgmcHJpdmF0 ZSwgMCwgc2l6ZW9mKFhMb2dQYWdlUmVhZFByaXZhdGUpKTsKQEAgLTc0ODgsMTMgKzc0ODcs NiBAQCBTdGFydHVwWExPRyh2b2lkKQogCWlmIChJblJlY292ZXJ5KQogCQlSZXNldFVubG9n Z2VkUmVsYXRpb25zKFVOTE9HR0VEX1JFTEFUSU9OX0lOSVQpOwogCi0JLyoKLQkgKiBXZSBk b24ndCBuZWVkIHRoZSBsYXRjaCBhbnltb3JlLiBJdCdzIG5vdCBzdHJpY3RseSBuZWNlc3Nh cnkgdG8gZGlzb3duCi0JICogaXQsIGJ1dCBsZXQncyBkbyBpdCBmb3IgdGhlIHNha2Ugb2Yg dGlkaW5lc3MuCi0JICovCi0JaWYgKEFyY2hpdmVSZWNvdmVyeVJlcXVlc3RlZCkKLQkJRGlz b3duTGF0Y2goJlhMb2dDdGwtPnJlY292ZXJ5V2FrZXVwTGF0Y2gpOwotCiAJLyoKIAkgKiBX ZSBhcmUgbm93IGRvbmUgcmVhZGluZyB0aGUgeGxvZyBmcm9tIHN0cmVhbS4gVHVybiBvZmYg c3RyZWFtaW5nCiAJICogcmVjb3ZlcnkgdG8gZm9yY2UgZmV0Y2hpbmcgdGhlIGZpbGVzICh3 aGljaCB3b3VsZCBiZSByZXF1aXJlZCBhdCBlbmQgb2YKQEAgLTEyMjQ0LDEyICsxMjIzNiwx MiBAQCBXYWl0Rm9yV0FMVG9CZWNvbWVBdmFpbGFibGUoWExvZ1JlY1B0ciBSZWNQdHIsIGJv b2wgcmFuZEFjY2VzcywKIAkJCQkJCXdhaXRfdGltZSA9IHdhbF9yZXRyaWV2ZV9yZXRyeV9p bnRlcnZhbCAtCiAJCQkJCQkJKHNlY3MgKiAxMDAwICsgdXNlY3MgLyAxMDAwKTsKIAotCQkJ CQkJKHZvaWQpIFdhaXRMYXRjaCgmWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCwKKwkJ CQkJCSh2b2lkKSBXYWl0TGF0Y2goTXlMYXRjaCwKIAkJCQkJCQkJCQkgV0xfTEFUQ0hfU0VU IHwgV0xfVElNRU9VVCB8CiAJCQkJCQkJCQkJIFdMX0VYSVRfT05fUE1fREVBVEgsCiAJCQkJ CQkJCQkJIHdhaXRfdGltZSwKIAkJCQkJCQkJCQkgV0FJVF9FVkVOVF9SRUNPVkVSWV9SRVRS SUVWRV9SRVRSWV9JTlRFUlZBTCk7Ci0JCQkJCQlSZXNldExhdGNoKCZYTG9nQ3RsLT5yZWNv dmVyeVdha2V1cExhdGNoKTsKKwkJCQkJCVJlc2V0TGF0Y2goTXlMYXRjaCk7CiAJCQkJCQlu b3cgPSBHZXRDdXJyZW50VGltZXN0YW1wKCk7CiAJCQkJCX0KIAkJCQkJbGFzdF9mYWlsX3Rp bWUgPSBub3c7CkBAIC0xMjUwMCwxMSArMTI0OTIsMTEgQEAgV2FpdEZvcldBTFRvQmVjb21l QXZhaWxhYmxlKFhMb2dSZWNQdHIgUmVjUHRyLCBib29sIHJhbmRBY2Nlc3MsCiAJCQkJCSAq IHRvIHJlYWN0IHRvIGEgdHJpZ2dlciBmaWxlIHByb21wdGx5IGFuZCB0byBjaGVjayBpZiB0 aGUKIAkJCQkJICogV0FMIHJlY2VpdmVyIGlzIHN0aWxsIGFjdGl2ZS4KIAkJCQkJICovCi0J CQkJCSh2b2lkKSBXYWl0TGF0Y2goJlhMb2dDdGwtPnJlY292ZXJ5V2FrZXVwTGF0Y2gsCisJ CQkJCSh2b2lkKSBXYWl0TGF0Y2goTXlMYXRjaCwKIAkJCQkJCQkJCSBXTF9MQVRDSF9TRVQg fCBXTF9USU1FT1VUIHwKIAkJCQkJCQkJCSBXTF9FWElUX09OX1BNX0RFQVRILAogCQkJCQkJ CQkJIDUwMDBMLCBXQUlUX0VWRU5UX1JFQ09WRVJZX1dBTF9TVFJFQU0pOwotCQkJCQlSZXNl dExhdGNoKCZYTG9nQ3RsLT5yZWNvdmVyeVdha2V1cExhdGNoKTsKKwkJCQkJUmVzZXRMYXRj aChNeUxhdGNoKTsKIAkJCQkJYnJlYWs7CiAJCQkJfQogCkBAIC0xMjY3Niw3ICsxMjY2OCw3 IEBAIENoZWNrUHJvbW90ZVNpZ25hbCh2b2lkKQogdm9pZAogV2FrZXVwUmVjb3Zlcnkodm9p ZCkKIHsKLQlTZXRMYXRjaCgmWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCk7CisJU2V0 TGF0Y2goWExvZ0N0bC0+cmVjb3ZlcnlXYWtldXBMYXRjaCk7CiB9CiAKIC8qCmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3N0YXJ0dXAuYyBiL3NyYy9iYWNrZW5kL3Bv c3RtYXN0ZXIvc3RhcnR1cC5jCmluZGV4IDY0YWY3Yjg3MDcuLmVhYjljOGM0ZWQgMTAwNjQ0 Ci0tLSBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvc3RhcnR1cC5jCisrKyBiL3NyYy9iYWNr ZW5kL3Bvc3RtYXN0ZXIvc3RhcnR1cC5jCkBAIC0zNyw3ICszNyw2IEBACiAvKgogICogRmxh Z3Mgc2V0IGJ5IGludGVycnVwdCBoYW5kbGVycyBmb3IgbGF0ZXIgc2VydmljZSBpbiB0aGUg cmVkbyBsb29wLgogICovCi1zdGF0aWMgdm9sYXRpbGUgc2lnX2F0b21pY190IGdvdF9TSUdI VVAgPSBmYWxzZTsKIHN0YXRpYyB2b2xhdGlsZSBzaWdfYXRvbWljX3Qgc2h1dGRvd25fcmVx dWVzdGVkID0gZmFsc2U7CiBzdGF0aWMgdm9sYXRpbGUgc2lnX2F0b21pY190IHByb21vdGVf c2lnbmFsZWQgPSBmYWxzZTsKIApAQCAtNDksNyArNDgsNiBAQCBzdGF0aWMgdm9sYXRpbGUg c2lnX2F0b21pY190IGluX3Jlc3RvcmVfY29tbWFuZCA9IGZhbHNlOwogCiAvKiBTaWduYWwg aGFuZGxlcnMgKi8KIHN0YXRpYyB2b2lkIFN0YXJ0dXBQcm9jVHJpZ2dlckhhbmRsZXIoU0lH TkFMX0FSR1MpOwotc3RhdGljIHZvaWQgU3RhcnR1cFByb2NTaWdIdXBIYW5kbGVyKFNJR05B TF9BUkdTKTsKIAogCiAvKiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAt NjQsMTkgKzYyLDcgQEAgU3RhcnR1cFByb2NUcmlnZ2VySGFuZGxlcihTSUdOQUxfQVJHUykK IAlpbnQJCQlzYXZlX2Vycm5vID0gZXJybm87CiAKIAlwcm9tb3RlX3NpZ25hbGVkID0gdHJ1 ZTsKLQlXYWtldXBSZWNvdmVyeSgpOwotCi0JZXJybm8gPSBzYXZlX2Vycm5vOwotfQotCi0v KiBTSUdIVVA6IHNldCBmbGFnIHRvIHJlLXJlYWQgY29uZmlnIGZpbGUgYXQgbmV4dCBjb252 ZW5pZW50IHRpbWUgKi8KLXN0YXRpYyB2b2lkCi1TdGFydHVwUHJvY1NpZ0h1cEhhbmRsZXIo U0lHTkFMX0FSR1MpCi17Ci0JaW50CQkJc2F2ZV9lcnJubyA9IGVycm5vOwotCi0JZ290X1NJ R0hVUCA9IHRydWU7Ci0JV2FrZXVwUmVjb3ZlcnkoKTsKKwlTZXRMYXRjaChNeUxhdGNoKTsK IAogCWVycm5vID0gc2F2ZV9lcnJubzsKIH0KQEAgLTkxLDcgKzc3LDcgQEAgU3RhcnR1cFBy b2NTaHV0ZG93bkhhbmRsZXIoU0lHTkFMX0FSR1MpCiAJCXByb2NfZXhpdCgxKTsKIAllbHNl CiAJCXNodXRkb3duX3JlcXVlc3RlZCA9IHRydWU7Ci0JV2FrZXVwUmVjb3ZlcnkoKTsKKwlT ZXRMYXRjaChNeUxhdGNoKTsKIAogCWVycm5vID0gc2F2ZV9lcnJubzsKIH0KQEAgLTEzNyw5 ICsxMjMsOSBAQCBIYW5kbGVTdGFydHVwUHJvY0ludGVycnVwdHModm9pZCkKIAkvKgogCSAq IFByb2Nlc3MgYW55IHJlcXVlc3RzIG9yIHNpZ25hbHMgcmVjZWl2ZWQgcmVjZW50bHkuCiAJ ICovCi0JaWYgKGdvdF9TSUdIVVApCisJaWYgKENvbmZpZ1JlbG9hZFBlbmRpbmcpCiAJewot CQlnb3RfU0lHSFVQID0gZmFsc2U7CisJCUNvbmZpZ1JlbG9hZFBlbmRpbmcgPSBmYWxzZTsK IAkJU3RhcnR1cFJlcmVhZENvbmZpZygpOwogCX0KIApAQCAtMTcyLDcgKzE1OCw3IEBAIFN0 YXJ0dXBQcm9jZXNzTWFpbih2b2lkKQogCS8qCiAJICogUHJvcGVybHkgYWNjZXB0IG9yIGln bm9yZSBzaWduYWxzIHRoZSBwb3N0bWFzdGVyIG1pZ2h0IHNlbmQgdXMuCiAJICovCi0JcHFz aWduYWwoU0lHSFVQLCBTdGFydHVwUHJvY1NpZ0h1cEhhbmRsZXIpOyAvKiByZWxvYWQgY29u ZmlnIGZpbGUgKi8KKwlwcXNpZ25hbChTSUdIVVAsIFNpZ25hbEhhbmRsZXJGb3JDb25maWdS ZWxvYWQpOyAvKiByZWxvYWQgY29uZmlnIGZpbGUgKi8KIAlwcXNpZ25hbChTSUdJTlQsIFNJ R19JR04pOwkvKiBpZ25vcmUgcXVlcnkgY2FuY2VsICovCiAJcHFzaWduYWwoU0lHVEVSTSwg U3RhcnR1cFByb2NTaHV0ZG93bkhhbmRsZXIpOwkvKiByZXF1ZXN0IHNodXRkb3duICovCiAJ LyogU0lHUVVJVCBoYW5kbGVyIHdhcyBhbHJlYWR5IHNldCB1cCBieSBJbml0UG9zdG1hc3Rl ckNoaWxkICovCg== --------------684DC038719271D441C94BFC--