From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
cc: jian he <jian.universality@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: add a new explain option including_query for include query string inside the json plan output
In-reply-to: <CAEze2WgJ9kqD2Kj2+=VcyJqqNrpNta2aUEu=MpqjjO4sKEey3Q@mail.gmail.com>
References: <CACJufxH33RAWJ26ayKNVV+utgya75RwXEDyCkkxZ38xoRPrCmw@mail.gmail.com> <CAEze2WgJ9kqD2Kj2+=VcyJqqNrpNta2aUEu=MpqjjO4sKEey3Q@mail.gmail.com>
Comments: In-reply-to Matthias van de Meent <boekewurm+postgres@gmail.com>
	message dated "Tue, 25 Jun 2024 12:30:27 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1319006.1719325433.1@sss.pgh.pa.us>
Date: Tue, 25 Jun 2024 10:23:53 -0400
Message-ID: <1319007.1719325433@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1319007.1719325433%40sss.pgh.pa.us>
Precedence: bulk

Matthias van de Meent <boekewurm+postgres@gmail.com> writes:
> On Tue, 25 Jun 2024 at 10:55, jian he <jian.universality@gmail.com> wrote:
>> for json format, add a new option to let the explain json output also
>> include the actual query string.

> Wouldn't the user be able to keep track of the query they wanted
> explained by themselves? If not, why?

Indeed.  I do not think this is a good idea at all, even if the
question of "where did you get the query string from" could be
resolved satisfactorily.

			regards, tom lane