From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        Corey Huinker <corey.huinker@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Michael Paquier <michael@paquier.xyz>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Bruce Momjian <bruce@momjian.us>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Magnus Hagander <magnus@hagander.net>,
        Stephen Frost <sfrost@snowman.net>,
        Peter Smith <smithpb2250@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        jian he <jian.universality@gmail.com>
Subject: Re: Statistics Import and Export: difference in statistics dumped
In-reply-to: <1116282.1741374848@sss.pgh.pa.us>
References: 
 <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
 <1457469.1740419458@sss.pgh.pa.us>
 <CADkLM=eWSv2z_DVB=psfwHitq7DbFJQaP9A46R27eARC-4OYtQ@mail.gmail.com>
 <cpdanvzykcb5o64rmapkx6n5gjypoce3y52hff7ocxupgpbxu4@53jmlyvukijo>
 <CADkLM=dX67xer59tVYMCQZ+pHAT2sCyyrUDzeDCdW_TdxqwOgA@mail.gmail.com>
 <curtrasm6ylt7es2ukfuals2mh5an72yzxgvyel65mw3ere7qs@nw6m4ffpo4m3>
 <8d13e4296408c53a93390525d0bcb906cbd13df4.camel@j-davis.com>
 <CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com>
 <CAExHW5vf9D+8-a5_BEX3y=2y_xY9hiCxV1=C+FnxDvfprWvkng@mail.gmail.com>
 <768b2a237e892bf1334bdcbb066cdc1bd1368cb2.camel@j-davis.com>
 <CAExHW5ttputnXg2!
 ! 31arxPWWScP7MkZjqRNjt4jPeht5GfypErw@mail.gmail.com>
 <5053263e41692dc2358a642403e9aa6fcda53578.camel@j-davis.com>
 <CAExHW5uL3++omHqoun2wMU0EUwb7R26F=SjCne6wZDGJzE3VOw@mail.gmail.com>
 <d6e08fde8cb173b34a96c7d2bc9985aa657ce51f.camel@j-davis.com>
 <CAExHW5sNgxkqkyscm9KRrcwvi+_Hg=PRe_u+xZYJzX+w4XAMjQ@mail.gmail.com>
 <ca81cbf6e6ea2af838df972801ad4da52640a503.camel@j-davis.com>
 <CAExHW5sEjLx-8r85+r=mL=o4jVx2Y0D-mRzGTZxcfNm4YSeRSQ@mail.gmail.com>
 <c720ac7bf88721947faf87e174ed8e0d10c782eb.camel@j-davis.com>
 <1116282.1741374848@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 07 Mar 2025 14:14:08 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1322261.1741643606.1@sss.pgh.pa.us>
Date: Mon, 10 Mar 2025 17:53:26 -0400
Message-ID: <1322262.1741643606@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1322262.1741643606%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I think what is happening is that the patch shut off CREATE
> INDEX's update of not only the table's stats but also the
> index's stats.  This seems unhelpful: the index's empty
> stats can never be what's wanted.

I looked at this more closely and realized that it's a simple matter
of having made the tests in the wrong order.  The whole stanza
should only apply when dealing with the table, not the index.

I verified that this change fixes the cross-version-upgrade
failure in local testing, and pushed it.

			regards, tom lane