Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id E727116D90F8 for ; Tue, 27 Mar 2012 14:22:38 -0300 (ADT) Received: from mailout-de.gmx.net ([213.165.64.22]) by makus.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1SCa6P-0004Rx-7s for pgsql-hackers@postgresql.org; Tue, 27 Mar 2012 17:22:37 +0000 Received: (qmail invoked by alias); 27 Mar 2012 17:22:19 -0000 Received: from a88-115-218-87.elisa-laajakaista.fi (EHLO [10.0.0.108]) [88.115.218.87] by mail.gmx.net (mp038) with SMTP; 27 Mar 2012 19:22:19 +0200 X-Authenticated: #495269 X-Provags-ID: V01U2FsdGVkX1/STx8+5hPSwyJNUwlHi0TPlE81eNQ1qcpyICJEB/ 5ZpYqZus0z8Ez9 Message-ID: <1332868938.24269.1.camel@vanquo.pezone.net> Subject: Re: Another review of URI for libpq, v7 submission From: Peter Eisentraut To: Alex Cc: pgsql-hackers Date: Tue, 27 Mar 2012 20:22:18 +0300 In-Reply-To: <87k42cb9dr.fsf@commandprompt.com> References: <87d38eaq3f.fsf@commandprompt.com> <87k42lsgck.fsf@commandprompt.com> <20120317145110.GA25172@gmail.com> <8762dyuda3.fsf@commandprompt.com> <87k42cb9dr.fsf@commandprompt.com> Content-Type: multipart/mixed; boundary="=-Tzc4aUDpt31UpacOf0SB" X-Mailer: Evolution 3.2.2-1 Mime-Version: 1.0 X-Y-GMX-Trusted: 0 X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201203/1640 X-Sequence-Number: 205522 --=-Tzc4aUDpt31UpacOf0SB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On tor, 2012-03-22 at 23:42 +0200, Alex wrote: > Okay, at last here's v9, rebased against current master branch. Attached is a patch on top of your v9 with two small fixes: - Don't provide a check target in libpq/Makefile if it's not implemented. - Use the configured port number for running the tests (otherwise it runs against my system installation, for example). --=-Tzc4aUDpt31UpacOf0SB Content-Disposition: attachment; filename="libpq-uri-v9+petere.patch" Content-Type: text/x-patch; name="libpq-uri-v9+petere.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit diff --git i/src/interfaces/libpq/Makefile w/src/interfaces/libpq/Makefile index f19f272..266e3db 100644 --- i/src/interfaces/libpq/Makefile +++ w/src/interfaces/libpq/Makefile @@ -121,7 +121,7 @@ install: all installdirs install-lib $(INSTALL_DATA) $(srcdir)/pqexpbuffer.h '$(DESTDIR)$(includedir_internal)' $(INSTALL_DATA) $(srcdir)/pg_service.conf.sample '$(DESTDIR)$(datadir)/pg_service.conf.sample' -check installcheck: +installcheck: $(MAKE) -C test $@ installdirs: installdirs-lib diff --git i/src/interfaces/libpq/test/Makefile w/src/interfaces/libpq/test/Makefile index 964bb20..869a2f0 100644 --- i/src/interfaces/libpq/test/Makefile +++ w/src/interfaces/libpq/test/Makefile @@ -5,7 +5,7 @@ include $(top_builddir)/src/Makefile.global all: installcheck installcheck: - BINDIR='$(bindir)' SUBDIR='$(subdir)' $(SHELL) ./regress.sh + BINDIR='$(bindir)' PGPORT='$(DEF_PGPORT)' SUBDIR='$(subdir)' $(SHELL) ./regress.sh clean distclean maintainer-clean: rm -f regress.out regress.diff --=-Tzc4aUDpt31UpacOf0SB--