Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229])
	by mail.postgresql.org (Postfix) with ESMTP id 02F1A12FE952
	for <pgsql-hackers@postgresql.org>;
	Thu,  5 Apr 2012 13:52:30 -0300 (ADT)
Received: from mailout-de.gmx.net ([213.165.64.22])
	by magus.postgresql.org with smtp (Exim 4.72)
	(envelope-from <peter_e@gmx.net>) id 1SFpvA-0001Dx-Tc
	for pgsql-hackers@postgresql.org; Thu, 05 Apr 2012 16:52:30 +0000
Received: (qmail invoked by alias); 05 Apr 2012 16:52:15 -0000
Received: from a88-115-218-87.elisa-laajakaista.fi (EHLO [10.0.0.108])
	[88.115.218.87]
	by mail.gmx.net (mp040) with SMTP; 05 Apr 2012 18:52:15 +0200
X-Authenticated: #495269
X-Provags-ID: V01U2FsdGVkX19RYKRf6uNRNLQnP+b0hVYwOam07dO5VR1dxCIekz
	1DG4L5OdYlHZ5I
Message-ID: <1333644733.2524.0.camel@vanquo.pezone.net>
Subject: Re: Another review of URI for libpq, v7 submission
From: Peter Eisentraut <peter_e@gmx.net>
To: Alex <ash@commandprompt.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers
	<pgsql-hackers@postgresql.org>
Date: Thu, 05 Apr 2012 19:52:13 +0300
In-Reply-To: <87pqbxk6bf.fsf@commandprompt.com>
References: 
 <CAAZKuFZ6d5aB8Tt-vq=xdCA4xEcLTDYK_d+G2VunpSuuqyKktA@mail.gmail.com>
	<87d38eaq3f.fsf@commandprompt.com>
	<CAAZKuFYKZbXhFyXiQOHx87Qq7MbzhN2iaqN_SFCQu3fkCV6Z7Q@mail.gmail.com>
	<87k42lsgck.fsf@commandprompt.com> <20120317145110.GA25172@gmail.com>
	<8762dyuda3.fsf@commandprompt.com> <87k42cb9dr.fsf@commandprompt.com>
	<1332868938.24269.1.camel@vanquo.pezone.net>
	<87ty19kfz0.fsf@commandprompt.com> <87pqbxk6bf.fsf@commandprompt.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.2-1 
Content-Transfer-Encoding: 8bit
Mime-Version: 1.0
X-Y-GMX-Trusted: 0
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201204/238
X-Sequence-Number: 206041

On ons, 2012-03-28 at 01:49 +0300, Alex wrote:
> Attached is a gzipped v10, complete with the above fixes and fixes to
> bugs found by Heikki.  Documentation and code comments are also
> finally updated.

The compiler warning is still there:

fe-connect.c: In function ‘conninfo_parse’:
fe-connect.c:4122:20: error: unused variable ‘option’ [-Werror=unused-variable]