From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        hlinnaka <hlinnaka@iki.fi>
Subject: Re: SerializeParamList vs machines with strict alignment
In-reply-to: 
 <CAA4eK1KR-v0fDy+3Osb+dok_+qU2WwijkF8WsUmpBrTcJF+o2Q@mail.gmail.com>
References: <11629.1536550032@sss.pgh.pa.us>
 <CAA4eK1JfEc=cqiUiRvUcHYCf=PVEwM_bZ_QiOMHpqGpUMdY8gA@mail.gmail.com>
 <8352.1536586500@sss.pgh.pa.us>
 <CAA4eK1KTsNC--yPBatOiLJriBfGNgb_vmTF40JcEeZPedcL9YA@mail.gmail.com>
 <CAA4eK1KjGVrbMxaoE=tr1uR7mfpVLYui60tO4ANkQQAV+c+Y_A@mail.gmail.com>
 <27748.1538425312@sss.pgh.pa.us> <28627.1538426947@sss.pgh.pa.us>
 <CAEepm=1QkD_udoP3sxc_fci7x3PXQu3-Q-E-oempRuciSNp05Q@mail.gmail.com>
 <4694.1538438514@sss.pgh.pa.us>
 <CAA4eK1JYfe-Sxi3RjjBTnf1y1d-TNK+9nt1-cLajBuaXnJM+8A@mail.gmail.com>
 <8134.1538444333@sss.pgh.pa.us>
 <CAA4eK1KFx+942LJSMt9-Z1p5yvmLqoXv78PaOsKYDgTnepTQ-g@mail.gmail.com>
 <12777.1538452350@sss.pgh.pa.us>
 <CAA4eK1KR-v0fDy+3Osb+dok_+qU2WwijkF8WsUmpBrTcJF+o2Q@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Tue, 02 Oct 2018 09:33:55 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13339.1538453286.1@sss.pgh.pa.us>
Date: Tue, 02 Oct 2018 00:08:06 -0400
Message-ID: <13340.1538453286@sss.pgh.pa.us>
Precedence: bulk

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Oct 2, 2018 at 9:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (I think we could drop the savepoint
>> too, no?)

> One advantage of keeping the savepoint is that we don't need to
> explicitly drop the objects which we have created temporarily for this
> test.

They'll go away anyway at the end of the transaction that the whole
script is wrapped in.  (But it might be worth choosing slightly less
generic object names, to avoid a conflict against other sub-tests
later in that script.)

			regards, tom lane