From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Fix comments in instr_time.h and remove an unneeded cast to int64
In-reply-to: <d398f38f-2444-451e-8fc4-58a9878541df@iki.fi>
References: <ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal> <d398f38f-2444-451e-8fc4-58a9878541df@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Tue, 06 Aug 2024 14:28:38 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1338737.1722954036.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 06 Aug 2024 10:20:36 -0400
Message-ID: <1338738.1722954036@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1338738.1722954036%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 06/08/2024 11:54, Bertrand Drouvot wrote:
>> Please find attached a tiny patch to correct those and, in passing, rem=
ove what
>> I think is an unneeded cast to int64.

> Applied, thanks!

I think this comment change is a dis-improvement.  It's removed the
documentation of the important fact that INSTR_TIME_GET_MICROSEC and
INSTR_TIME_GET_NANOSEC return a different data type from
INSTR_TIME_GET_MILLISEC (ie, integer versus float).  Also, the
expectation is that users of these APIs do not know the actual data
type of instr_time, and instead we tell them what the output of those
macros is.  This patch just blew a hole in that abstraction.

			regards, tom lane