From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Alexander Lakhin <exclusion@gmail.com>,
 Andres Freund <andres@anarazel.de>,
        pgsql-hackers <pgsql-hackers@postgresql.org>, greg@burd.me
Subject: Re: IO in wrong state on riscv64
In-reply-to: 
 <CA+hUKGLuNvLxdiwGQYjTWzh0W3JQoqegmOa9eOgpAPNDr-M+mg@mail.gmail.com>
References: <d79691be-22bd-457d-9d90-18033b78c40a@gmail.com>
 <CA+hUKG+X=FKYecrpZaWNkWJZkQQWu6v2LvcD4nof1UftF7nZ9A@mail.gmail.com>
 <60bbebf4-0a80-4e5f-83c0-311c85f6bd5c@gmail.com>
 <CA+hUKGKRZufVhDEc1NDUXXHpTd9Q8gmvqbU+2cOUJZnK_TYJGA@mail.gmail.com>
 <c4cf94c2-e61c-444b-814f-1df85e52a39f@gmail.com>
 <CA+hUKGLpP2T90M3eEPB95KfB4PtdfVnEUNH+aoRiXfSk-ODJkQ@mail.gmail.com>
 <f2378a85-c968-4ccf-acf3-bca6f5c50c87@gmail.com>
 <CA+hUKGKcdkNTkn9C2MT3zM3ZTVLZTZTiLKXkWVDYWh4w7MNACA@mail.gmail.com>
 <CA+hUKGJKqC2VSg8_MCB4_3air3Zhk8x8K99KxHtLuoFFdVFnvg@mail.gmail.com>
 <w3qc4gzqywinffeglpwyxbwocpsjvh3yqqy5d42zsqhciy3yr5@tb63f2ipdzrl>
 <CA+hUKGLJHW7QjNGpfo+yKD6GzhdVnHxaSf0QJZp4VTu7jAt68A@mail.gmail.com>
 <927941c8-e5a1-4787-bbd9-88f0d92b55d0@gmail.com>
 <CA+hUKGKt5o70MB0Yj8QYNOjR3xTH8fTJQ09WdkvA_Rdg-Qag8w@mail.gmail.com>
 <CA+hUKGJt82c69MwXwxCnYJTJadMmmtVqeZnApQCJPoVyOOZR1A@mail.gmail.com>
 <1338407.1762560226@sss.pgh.pa.us>
 <CA+hUKGLuNvLxdiwGQYjTWzh0W3JQoqegmOa9eOgpAPNDr-M+mg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sat, 08 Nov 2025 13:13:32 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1340545.1762561464.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 07 Nov 2025 19:24:24 -0500
Message-ID: <1340546.1762561464@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1340546.1762561464%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Sat, Nov 8, 2025 at 1:03 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> You're a brave man to be pushing this into the last-ever release
>> of v13 with all of 12 hours remaining till code freeze.  I don't
>> mind so much for the newer branches, but I'm feeling nervous
>> about the risk/reward ratio for v13.

> I figured "adding a no-op compiler barrier where we already believed
> there to be a compiler barrier and rely on it crucially" was pretty
> safe as these things go, but that's a good point about v13 and I can
> revert it in that one branch in a couple of hours if that's the
> consensus.

It looks fairly safe to me too, or I'd be pushing back harder.
Still, we routinely get burnt by things we push into a branch's
final release, so I think it's worth having a discussion about
whether this has any possible downsides.

			regards, tom lane